New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] - Rename esql setting #182432

Merged

jbudz merged 3 commits into elastic:main from michaelolo24:rename-esql-setting

May 2, 2024

Contributor

michaelolo24 commented May 2, 2024 •

edited by kibanamachine

Loading

Summary

Follow up to this PR: #181616
Renaming discover:enableEsql to enableESQL according to this change: #182074

michaelolo24 added release_note:skip Team:Threat Hunting:Investigations v8.14.0 v8.15.0 labels

michaelolo24 added this to the 8.14 milestone

michaelolo24 requested a review from a team as a code owner

May 2, 2024 17:20

Contributor

elasticmachine commented May 2, 2024

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

michaelolo24 enabled auto-merge (squash)

May 2, 2024 17:23

vitaliidm approved these changes

View reviewed changes

vitaliidm reviewed

View reviewed changes

x-pack/plugins/security_solution/public/common/hooks/esql/use_esql_availability.ts Outdated

               export const useEsqlAvailability = () => {
                 const { uiSettings } = useKibana().services;
-                const isEsqlAdvancedSettingEnabled = uiSettings?.get('discover:enableESQL');
+                const isEsqlAdvancedSettingEnabled = uiSettings?.get('enableESQL');

Contributor

vitaliidm May 2, 2024

maybe we can use const variable according to #181616 (comment)

Contributor Author

michaelolo24 May 2, 2024

Yea, agreed. Done, just rushed a little to make BC3, but updated as I think we should be okay 😄

michaelolo24 added 3 commits

May 2, 2024 15:04


          rename setting

829a29c


          use const variable

8e6248f


          lint fix

06db5f9

michaelolo24 force-pushed the rename-esql-setting branch from 3600d48 to 06db5f9 Compare

May 2, 2024 19:04

jbudz disabled auto-merge

May 2, 2024 19:18

jbudz merged commit c053208 into elastic:main

3 of 7 checks passed

jbudz mentioned this pull request

[Security Solution] Fix assistant settings availability for non-superuser role #182322

Merged

This was referenced May 2, 2024

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/prebuilt_rules/install_via_fleet·cy·ts - Detection rules, Prebuilt Rules Installation and Update workflow Installation of prebuilt rules package via Fleet should install package from Fleet in the background should install package from Fleet in the background #182439

Open

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/prebuilt_rules/install_via_fleet·cy·ts - Detection rules, Prebuilt Rules Installation and Update workflow Installation of prebuilt rules package via Fleet should install rules from the Fleet package when user clicks on CTA should install rules from the Fleet package when user clicks on CTA #182440

Open

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/prebuilt_rules/install_workflow·cy·ts - Detection rules, Prebuilt Rules Installation and Update workflow Installation of prebuilt rules "before each" hook for "should install prebuilt rules one by one" "before each" hook for "should install prebuilt rules one by one" #182441

Open

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/prebuilt_rules/management·cy·ts - Prebuilt rules Alerts rules, prebuilt rules "before each" hook for "Loads prebuilt rules" "before each" hook for "Loads prebuilt rules" #182442

Open

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/prebuilt_rules/install_update_authorization·cy·ts - Detection rules, Prebuilt Rules Installation and Update - Authorization/RBAC User with read privileges on Security Solution should not be able to upgrade prebuilt rules should not be able to upgrade prebuilt rules #182484

Open

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/prebuilt_rules/install_update_authorization·cy·ts - Detection rules, Prebuilt Rules Installation and Update - Authorization/RBAC User with write privileges on Security Solution should be able to install prebuilt rules should be able to install prebuilt rules #182485

Open

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/prebuilt_rules/install_update_authorization·cy·ts - Detection rules, Prebuilt Rules Installation and Update - Authorization/RBAC User with read privileges on Security Solution should not be able to install prebuilt rules should not be able to install prebuilt rules #182483

Open

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/prebuilt_rules/install_update_authorization·cy·ts - Detection rules, Prebuilt Rules Installation and Update - Authorization/RBAC User with write privileges on Security Solution should be able to upgrade prebuilt rules should be able to upgrade prebuilt rules #182486

Open

[Security Solution] Fix flaky tests: Rule Management team 8.15 #176909

Closed

Collaborator

kibana-ci commented May 2, 2024 •

edited

Loading

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #11 / Rules Management - Rule Bulk Action API @ess perform_bulk_action - ESS specific logic should enable rules and migrate actions
[job] [logs] FTR Configs #11 / Rules Management - Rule Bulk Action API @ess perform_bulk_action - ESS specific logic should enable rules and migrate actions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	13.7MB	13.7MB	+651.0B

History

💔 Build #207617 failed 3600d48

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine mentioned this pull request

[CI] Fix axios requests to allow retry #182386

Merged

yuliacech pushed a commit to yuliacech/kibana that referenced this pull request


          [Security Solution] - Rename esql setting (elastic#182432)

db57ca5

## Summary

Follow up to this PR: elastic#181616
Renaming `discover:enableEsql` to `enableESQL` according to this change:
elastic#182074

nastasha-solomon mentioned this pull request

[Request][ESS] Document advanced setting that allows users to disable ES|QL in ESS elastic/security-docs#5163

Closed

banderror mentioned this pull request

[Security Solution] Unskip tests broken by 181616 and fixed by 182432 #182682

Open

This was referenced May 6, 2024

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/exceptions/rule_details_flow/add_edit_exception_data_view·cy·ts - Add exception using data views from rule details "before each" hook for "Creates an exception item and close all matching alerts" "before each" hook for "Creates an exception item and close all matching alerts" #182447

Closed

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/exceptions/rule_details_flow/add_edit_endpoint_exception·cy·ts - Add endpoint exception from rule details without exception items creates an exception item creates an exception item #182468

Open

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/exceptions/rule_details_flow/add_edit_endpoint_exception·cy·ts - Add endpoint exception from rule details with exception items "before each" hook for "edits an endpoint exception item" "before each" hook for "edits an endpoint exception item" #182469

Closed

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/exceptions/entry/multiple_conditions·cy·ts - Add multiple conditions and validate the generated exceptions Use multipe OR conditions and validate it generates multiple exceptions Use multipe OR conditions and validate it generates multiple exceptions #182471

Closed

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/exceptions/entry/multiple_conditions·cy·ts - Add multiple conditions and validate the generated exceptions Use multipe AND conditions and validate it generates one exception Use multipe AND conditions and validate it generates one exception #182470

Closed

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/exceptions/entry/match_any·cy·ts - Exceptions match_any "before each" hook for "Creates exception item" "before each" hook for "Creates exception item" #182477

Closed

Contributor

kibanamachine commented Aug 3, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

kibanamachine added the backport missing label

Contributor

kibanamachine commented Aug 6, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

8 similar comments

Contributor

kibanamachine commented Aug 7, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

Contributor

kibanamachine commented Aug 11, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

Contributor

kibanamachine commented Aug 13, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

Contributor

kibanamachine commented Aug 14, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

Contributor

kibanamachine commented Aug 18, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

Contributor

kibanamachine commented Aug 19, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

Contributor

kibanamachine commented Aug 20, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

Contributor

kibanamachine commented Sep 16, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

jbudz added the backport:skip label

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip release_note:skip Team:Threat Hunting:Investigations v8.14.0 v8.15.0