[Onboarding] Fix failing Cypress tests #192577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
mykolaharmash
force-pushed
the
176995-fix-system-logs-onboarding-cypress-tests
branch
from
d4d8d38
to
a489b0f
Compare
mykolaharmash
commented
Sep 11, 2024
| @@ -5,8 +5,7 @@ | |||
| * 2.0. | |||
| */ | |||
|
|
|||
| // Failing: See https://github.com/elastic/kibana/issues/186215 | |||
| describe.skip('[Logs onboarding] Custom logs - configure step', () => { | |||
| describe('[Logs onboarding] Custom logs - configure step', () => { | |||
There was a problem hiding this comment.
I could not make this fail, suspect some other change already has "fixed" it as the issue is quite old at this point.
mykolaharmash
added
release_note:skip
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: |
|
Can you run this through the flaky test runner to make sure this doesn't break the build again? |
thomheymann
approved these changes
Sep 12, 2024
botelastic
bot
added
the
ci:project-deploy-observability
kibanamachine
added
v8.16.0
backport:skip
1 task
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Sep 13, 2024
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176995
Closes #186215