Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Onboarding] Fix failing Cypress tests #192577

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[Onboarding] Fix failing Cypress tests #192577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...bility_solution/observability_onboarding/e2e/cypress/e2e/logs/custom_logs/configure.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
* 2.0.
*/

// Failing: See https://github.com/elastic/kibana/issues/186215
describe.skip('[Logs onboarding] Custom logs - configure step', () => {
describe('[Logs onboarding] Custom logs - configure step', () => {
Copy link
Contributor Author

@mykolaharmash mykolaharmash Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not make this fail, suspect some other change already has "fixed" it as the issue is quite old at this point.

describe('logFilePaths', () => {
beforeEach(() => {
cy.loginAsViewerUser();
Expand Down
6 changes: 2 additions & 4 deletions ...ns/observability_solution/observability_onboarding/e2e/cypress/e2e/logs/system_logs.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,9 +542,7 @@ describe('[Logs onboarding] System logs', () => {
});
});

// Skpping this test because it's failing in the CI
// https://github.com/elastic/kibana/issues/176995
xdescribe('when integration installation succeed', () => {
describe('when integration installation succeed', () => {
beforeEach(() => {
cy.deleteIntegration('system');
cy.intercept('GET', '/api/fleet/epm/packages/system').as('systemIntegrationInstall');
Expand All @@ -557,7 +555,7 @@ describe('[Logs onboarding] System logs', () => {
cy.getByTestSubj('obltOnboardingExploreLogs').should('exist').click();

cy.url().should('include', '/app/observability-logs-explorer');
cy.get('button').contains('[System] syslog').should('exist');
cy.get('button').contains('[system] system.syslog').should('exist');
});
});
});
Expand Down