-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automatic Import] Add Error handling framework #193577
[Automatic Import] Add Error handling framework #193577
Conversation
2a6bed6
to
6486b9c
Compare
export const RECURSION_LIMIT_ERROR = i18n.translate( | ||
'xpack.plugins.integration_assistant.server.errors.recursionLimitReached', | ||
{ | ||
defaultMessage: 'Max attempts exceeded. Please try again.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamiehynds Need a better wording here.
Pinging @elastic/security-scalability (Team:Security-Scalability) |
6486b9c
to
73106e0
Compare
81d7d9a
to
a568412
Compare
.../create_integration/create_integration_assistant/steps/data_stream_step/generation_modal.tsx
Outdated
Show resolved
Hide resolved
...nents/create_integration/create_integration_assistant/steps/data_stream_step/translations.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/routes/routes_util.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @bhapas |
## Release Note Adds error handling framework that provides error message with more context to user. ## Summary Relates - [192916](elastic#192916) This PR adds an error handling framework. - Add Error classes for specific error scenarios. - If the error caught is of the predefined Error type the `message` and `errorCode` is sent back to UI from server. - The original error message is used to track telemetry and the errorCode can be translated into a User visible error. - If there is any non-predefined error server still throws a `badRequest` with the error message. This PR also adds/updates the graph images for different langgraphs ## Screenshots for error messages <img width="690" alt="image" src="https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea"> <img width="691" alt="image" src="https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 9fb6f55)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
) # Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Add Error handling framework (#193577)](#193577) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-25T14:24:01Z","message":"[Automatic Import] Add Error handling framework (#193577)\n\n## Release Note\r\n\r\nAdds error handling framework that provides error message with more\r\ncontext to user.\r\n\r\n## Summary\r\n\r\nRelates - [192916](https://github.com/elastic/kibana/issues/192916)\r\n\r\nThis PR adds an error handling framework.\r\n- Add Error classes for specific error scenarios.\r\n- If the error caught is of the predefined Error type the `message` and\r\n`errorCode` is sent back to UI from server.\r\n- The original error message is used to track telemetry and the\r\nerrorCode can be translated into a User visible error.\r\n- If there is any non-predefined error server still throws a\r\n`badRequest` with the error message.\r\n\r\nThis PR also adds/updates the graph images for different langgraphs\r\n\r\n## Screenshots for error messages\r\n<img width=\"690\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea\">\r\n\r\n<img width=\"691\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9fb6f5582220148820fb6b83880539f8df0b0841","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["enhancement","v9.0.0","release_note:feature","backport:prev-minor","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic Import] Add Error handling framework","number":193577,"url":"https://github.com/elastic/kibana/pull/193577","mergeCommit":{"message":"[Automatic Import] Add Error handling framework (#193577)\n\n## Release Note\r\n\r\nAdds error handling framework that provides error message with more\r\ncontext to user.\r\n\r\n## Summary\r\n\r\nRelates - [192916](https://github.com/elastic/kibana/issues/192916)\r\n\r\nThis PR adds an error handling framework.\r\n- Add Error classes for specific error scenarios.\r\n- If the error caught is of the predefined Error type the `message` and\r\n`errorCode` is sent back to UI from server.\r\n- The original error message is used to track telemetry and the\r\nerrorCode can be translated into a User visible error.\r\n- If there is any non-predefined error server still throws a\r\n`badRequest` with the error message.\r\n\r\nThis PR also adds/updates the graph images for different langgraphs\r\n\r\n## Screenshots for error messages\r\n<img width=\"690\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea\">\r\n\r\n<img width=\"691\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9fb6f5582220148820fb6b83880539f8df0b0841"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193577","number":193577,"mergeCommit":{"message":"[Automatic Import] Add Error handling framework (#193577)\n\n## Release Note\r\n\r\nAdds error handling framework that provides error message with more\r\ncontext to user.\r\n\r\n## Summary\r\n\r\nRelates - [192916](https://github.com/elastic/kibana/issues/192916)\r\n\r\nThis PR adds an error handling framework.\r\n- Add Error classes for specific error scenarios.\r\n- If the error caught is of the predefined Error type the `message` and\r\n`errorCode` is sent back to UI from server.\r\n- The original error message is used to track telemetry and the\r\nerrorCode can be translated into a User visible error.\r\n- If there is any non-predefined error server still throws a\r\n`badRequest` with the error message.\r\n\r\nThis PR also adds/updates the graph images for different langgraphs\r\n\r\n## Screenshots for error messages\r\n<img width=\"690\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea\">\r\n\r\n<img width=\"691\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9fb6f5582220148820fb6b83880539f8df0b0841"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Release Note Adds error handling framework that provides error message with more context to user. ## Summary Relates - [192916](elastic#192916) This PR adds an error handling framework. - Add Error classes for specific error scenarios. - If the error caught is of the predefined Error type the `message` and `errorCode` is sent back to UI from server. - The original error message is used to track telemetry and the errorCode can be translated into a User visible error. - If there is any non-predefined error server still throws a `badRequest` with the error message. This PR also adds/updates the graph images for different langgraphs ## Screenshots for error messages <img width="690" alt="image" src="https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea"> <img width="691" alt="image" src="https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
elastic#194017) # Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Add Error handling framework (elastic#193577)](elastic#193577) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-25T14:24:01Z","message":"[Automatic Import] Add Error handling framework (elastic#193577)\n\n## Release Note\r\n\r\nAdds error handling framework that provides error message with more\r\ncontext to user.\r\n\r\n## Summary\r\n\r\nRelates - [192916](https://github.com/elastic/kibana/issues/192916)\r\n\r\nThis PR adds an error handling framework.\r\n- Add Error classes for specific error scenarios.\r\n- If the error caught is of the predefined Error type the `message` and\r\n`errorCode` is sent back to UI from server.\r\n- The original error message is used to track telemetry and the\r\nerrorCode can be translated into a User visible error.\r\n- If there is any non-predefined error server still throws a\r\n`badRequest` with the error message.\r\n\r\nThis PR also adds/updates the graph images for different langgraphs\r\n\r\n## Screenshots for error messages\r\n<img width=\"690\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea\">\r\n\r\n<img width=\"691\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9fb6f5582220148820fb6b83880539f8df0b0841","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["enhancement","v9.0.0","release_note:feature","backport:prev-minor","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic Import] Add Error handling framework","number":193577,"url":"https://github.com/elastic/kibana/pull/193577","mergeCommit":{"message":"[Automatic Import] Add Error handling framework (elastic#193577)\n\n## Release Note\r\n\r\nAdds error handling framework that provides error message with more\r\ncontext to user.\r\n\r\n## Summary\r\n\r\nRelates - [192916](https://github.com/elastic/kibana/issues/192916)\r\n\r\nThis PR adds an error handling framework.\r\n- Add Error classes for specific error scenarios.\r\n- If the error caught is of the predefined Error type the `message` and\r\n`errorCode` is sent back to UI from server.\r\n- The original error message is used to track telemetry and the\r\nerrorCode can be translated into a User visible error.\r\n- If there is any non-predefined error server still throws a\r\n`badRequest` with the error message.\r\n\r\nThis PR also adds/updates the graph images for different langgraphs\r\n\r\n## Screenshots for error messages\r\n<img width=\"690\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea\">\r\n\r\n<img width=\"691\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9fb6f5582220148820fb6b83880539f8df0b0841"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193577","number":193577,"mergeCommit":{"message":"[Automatic Import] Add Error handling framework (elastic#193577)\n\n## Release Note\r\n\r\nAdds error handling framework that provides error message with more\r\ncontext to user.\r\n\r\n## Summary\r\n\r\nRelates - [192916](https://github.com/elastic/kibana/issues/192916)\r\n\r\nThis PR adds an error handling framework.\r\n- Add Error classes for specific error scenarios.\r\n- If the error caught is of the predefined Error type the `message` and\r\n`errorCode` is sent back to UI from server.\r\n- The original error message is used to track telemetry and the\r\nerrorCode can be translated into a User visible error.\r\n- If there is any non-predefined error server still throws a\r\n`badRequest` with the error message.\r\n\r\nThis PR also adds/updates the graph images for different langgraphs\r\n\r\n## Screenshots for error messages\r\n<img width=\"690\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea\">\r\n\r\n<img width=\"691\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9fb6f5582220148820fb6b83880539f8df0b0841"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Release Note
Adds error handling framework that provides error message with more context to user.
Summary
Relates - 192916
This PR adds an error handling framework.
message
anderrorCode
is sent back to UI from server.badRequest
with the error message.This PR also adds/updates the graph images for different langgraphs
Screenshots for error messages
Checklist
For maintainers