[8.x] [Automatic Import] Add Error handling framework (#193577) #194017
+332
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Release Note Adds error handling framework that provides error message with more context to user. ## Summary Relates - [192916](elastic#192916) This PR adds an error handling framework. - Add Error classes for specific error scenarios. - If the error caught is of the predefined Error type the `message` and `errorCode` is sent back to UI from server. - The original error message is used to track telemetry and the errorCode can be translated into a User visible error. - If there is any non-predefined error server still throws a `badRequest` with the error message. This PR also adds/updates the graph images for different langgraphs ## Screenshots for error messages <img width="690" alt="image" src="https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea"> <img width="691" alt="image" src="https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 9fb6f55)
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bhapas
added
release_note:feature
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @bhapas |
neptunian
pushed a commit
to neptunian/kibana
that referenced
this pull request
Oct 1, 2024
elastic#194017) # Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Add Error handling framework (elastic#193577)](elastic#193577) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-25T14:24:01Z","message":"[Automatic Import] Add Error handling framework (elastic#193577)\n\n## Release Note\r\n\r\nAdds error handling framework that provides error message with more\r\ncontext to user.\r\n\r\n## Summary\r\n\r\nRelates - [192916](https://github.com/elastic/kibana/issues/192916)\r\n\r\nThis PR adds an error handling framework.\r\n- Add Error classes for specific error scenarios.\r\n- If the error caught is of the predefined Error type the `message` and\r\n`errorCode` is sent back to UI from server.\r\n- The original error message is used to track telemetry and the\r\nerrorCode can be translated into a User visible error.\r\n- If there is any non-predefined error server still throws a\r\n`badRequest` with the error message.\r\n\r\nThis PR also adds/updates the graph images for different langgraphs\r\n\r\n## Screenshots for error messages\r\n<img width=\"690\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea\">\r\n\r\n<img width=\"691\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9fb6f5582220148820fb6b83880539f8df0b0841","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["enhancement","v9.0.0","release_note:feature","backport:prev-minor","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic Import] Add Error handling framework","number":193577,"url":"https://github.com/elastic/kibana/pull/193577","mergeCommit":{"message":"[Automatic Import] Add Error handling framework (elastic#193577)\n\n## Release Note\r\n\r\nAdds error handling framework that provides error message with more\r\ncontext to user.\r\n\r\n## Summary\r\n\r\nRelates - [192916](https://github.com/elastic/kibana/issues/192916)\r\n\r\nThis PR adds an error handling framework.\r\n- Add Error classes for specific error scenarios.\r\n- If the error caught is of the predefined Error type the `message` and\r\n`errorCode` is sent back to UI from server.\r\n- The original error message is used to track telemetry and the\r\nerrorCode can be translated into a User visible error.\r\n- If there is any non-predefined error server still throws a\r\n`badRequest` with the error message.\r\n\r\nThis PR also adds/updates the graph images for different langgraphs\r\n\r\n## Screenshots for error messages\r\n<img width=\"690\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea\">\r\n\r\n<img width=\"691\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9fb6f5582220148820fb6b83880539f8df0b0841"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193577","number":193577,"mergeCommit":{"message":"[Automatic Import] Add Error handling framework (elastic#193577)\n\n## Release Note\r\n\r\nAdds error handling framework that provides error message with more\r\ncontext to user.\r\n\r\n## Summary\r\n\r\nRelates - [192916](https://github.com/elastic/kibana/issues/192916)\r\n\r\nThis PR adds an error handling framework.\r\n- Add Error classes for specific error scenarios.\r\n- If the error caught is of the predefined Error type the `message` and\r\n`errorCode` is sent back to UI from server.\r\n- The original error message is used to track telemetry and the\r\nerrorCode can be translated into a User visible error.\r\n- If there is any non-predefined error server still throws a\r\n`badRequest` with the error message.\r\n\r\nThis PR also adds/updates the graph images for different langgraphs\r\n\r\n## Screenshots for error messages\r\n<img width=\"690\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea\">\r\n\r\n<img width=\"691\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9fb6f5582220148820fb6b83880539f8df0b0841"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation