Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][skip ci] Maps read only access #35561

Merged
merged 6 commits into from
Aug 2, 2019
Merged

[docs][skip ci] Maps read only access #35561

merged 6 commits into from
Aug 2, 2019

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Apr 24, 2019 •
edited
Loading

With the addition of "read only mode" to Maps, we're displaying an indicator in the header to prompt users that they won't be able to create or save maps. This PR updates the documentation to also mention read-only mode and the operations which the user won't be able to perform.

@kobelb kobelb changed the title [docs][skip ci] Maps read only badge [docs][skip ci] Maps read only access Apr 24, 2019
@kobelb kobelb marked this pull request as ready for review May 24, 2019 17:10
kindsun
kindsun approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! did local run-through of process using user/role w/o maps privs.

@nreese
Copy link
Contributor

nreese commented May 30, 2019

Would you want to move the section under create map so it flows a little better?

@nreese nreese removed the request for review from thomasneirynck May 30, 2019 16:51
@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Docs v7.2.0 v8.0.0 labels May 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@nreese nreese added the v7.3.0 label May 30, 2019
@kobelb
Copy link
Contributor Author

kobelb commented May 30, 2019

Would you want to move the section under create map so it flows a little better?

I'm willing to put it wherever you all would prefer. Where would you want it to be moved to?

Screen Shot 2019-05-30 at 11 41 24 AM

@nreese
Copy link
Contributor

nreese commented May 30, 2019

Is there a reason why you placed the section in the getting started guide? Would it make sense to be outside of the getting started guide?

@kobelb
Copy link
Contributor Author

kobelb commented May 30, 2019

Is there a reason why you placed the section in the getting started guide? Would it make sense to be outside of the getting started guide?

I wanted it to be before we start talking about create/saving maps to let some users know why they wouldn't be able to perform those actions, and since the getting started guide talked in length about that it seemed to make sense there. It was also the easiest place for me to do so without reconfiguring a bunch of other things.

@nreese
Copy link
Contributor

nreese commented May 30, 2019

@gchaps Where would be the best place to add a section about "read only access"

gchaps
gchaps reviewed Jun 20, 2019
View reviewed changes
docs/maps/maps-getting-started.asciidoc Outdated Show resolved Hide resolved
docs/maps/maps-getting-started.asciidoc Outdated Show resolved Hide resolved
@gchaps
Copy link
Contributor

gchaps commented Jun 20, 2019

I think the content can stay where it is. However, the title "Read-only access" is misleading. How about using NOTE: instead of a title:

Screen Shot 2019-06-20 at 11 40 12 AM

@spalger spalger added v7.2.1 and removed v7.2.0 labels Jun 25, 2019
@spalger spalger added the v7.4.0 label Jul 3, 2019
@rayafratkina
Copy link
Contributor

@kobelb looks like this did not go in. Are we still planning to make this change?

@kobelb @gchaps
Apply suggestions from code review
7c06e3d 
Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
@kobelb
Copy link
Contributor Author

kobelb commented Jul 31, 2019

@kobelb looks like this did not go in. Are we still planning to make this change?

Yup, I'll make the requested change and get it merged.

@kobelb kobelb added the release_note:skip Skip the PR/issue when compiling release notes label Aug 2, 2019
@kobelb kobelb merged commit 9fbb95f into elastic:master Aug 2, 2019
@kobelb kobelb deleted the docs/readonly-maps branch August 2, 2019 22:52
@kobelb kobelb mentioned this pull request Aug 2, 2019
Merged
kobelb added a commit to kobelb/kibana that referenced this pull request Aug 2, 2019
@kobelb
[docs][skip ci] Maps read only access (elastic#35561)
50b86b3 
* Adding read only access to the maps docs

* Removing redundant x-pack label, maps is already x-pack only

* Apply suggestions from code review

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Switching to using a Note
@kobelb kobelb mentioned this pull request Aug 2, 2019
Merged
kobelb added a commit to kobelb/kibana that referenced this pull request Aug 2, 2019
@kobelb
[docs][skip ci] Maps read only access (elastic#35561)
125a959 
* Adding read only access to the maps docs

* Removing redundant x-pack label, maps is already x-pack only

* Apply suggestions from code review

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Switching to using a Note
@kobelb kobelb mentioned this pull request Aug 2, 2019
Merged
kobelb added a commit to kobelb/kibana that referenced this pull request Aug 2, 2019
@kobelb
[docs][skip ci] Maps read only access (elastic#35561)
52ce86a 
* Adding read only access to the maps docs

* Removing redundant x-pack label, maps is already x-pack only

* Apply suggestions from code review

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Switching to using a Note
kobelb added a commit that referenced this pull request Aug 2, 2019
@kobelb
[docs][skip ci] Maps read only access (#35561) (#42553)
5b00284 
* Adding read only access to the maps docs

* Removing redundant x-pack label, maps is already x-pack only

* Apply suggestions from code review

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Switching to using a Note
kobelb added a commit that referenced this pull request Aug 2, 2019
@kobelb
[docs][skip ci] Maps read only access (#35561) (#42554)
97d6773 
* Adding read only access to the maps docs

* Removing redundant x-pack label, maps is already x-pack only

* Apply suggestions from code review

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Switching to using a Note
kobelb added a commit that referenced this pull request Aug 2, 2019
@kobelb
[docs][skip ci] Maps read only access (#35561) (#42555)
c4e4287 
* Adding read only access to the maps docs

* Removing redundant x-pack label, maps is already x-pack only

* Apply suggestions from code review

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Switching to using a Note
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/clone…
ad759ef 
…-or-edit-existing-rollup-job

* 'master' of github.com:elastic/kibana: (67 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/doc_value…
b366497 
…s_autocomplete

* 'master' of github.com:elastic/kibana: (189 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@kindsun kindsun kindsun approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.2.1 v7.3.1 v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kobelb @nreese @elasticmachine @gchaps @rayafratkina @kindsun @spalger