Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ftr/cheerio] improve cheerio types to include test subject methods #42534

Merged
merged 1 commit into from
Aug 2, 2019
Merged

[ftr/cheerio] improve cheerio types to include test subject methods #42534

merged 1 commit into from
Aug 2, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Aug 2, 2019 •
edited
Loading

WebElementWrapper has a parseDomContent() method to retrieve a cheerio instance populated with the HTML of a dom element. This method currently returns an any, because typing the return value is a little tricky, especially since the return value is customized with additional methods for interacting with test subjects.

This PR implements the correct types so that they are accurate and helpful by extracting the Cheerio and CheerioStatic types from @types/cheerio and modifying them as necessary.

@spalger spalger added Team:Operations Team label for Operations Team test_infra v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.2.2 v7.3.1 labels Aug 2, 2019
@spalger spalger requested a review from dmlemeshko August 2, 2019 15:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

dmlemeshko
dmlemeshko approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit f4e3915 into elastic:master Aug 2, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 2, 2019
[ftr/cheerio] improve cheerio types to include test subject me… (elas…
d9834d8 
…tic#42534)
@spalger spalger mentioned this pull request Aug 2, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 2, 2019
[ftr/cheerio] improve cheerio types to include test subject me… (elas…
2d48377 
…tic#42534)
@spalger spalger mentioned this pull request Aug 2, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 2, 2019
[ftr/cheerio] improve cheerio types to include test subject me… (elas…
a6454d6 
…tic#42534)
@spalger spalger mentioned this pull request Aug 2, 2019
Merged
@spalger
Copy link
Contributor Author

spalger commented Aug 2, 2019

7.x/7.4: 91b40d2
7.3: ab19a2e
7.2: e50a6ab

@spalger spalger deleted the improve-ftr-cheerio-types branch August 2, 2019 22:52
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/clone…
ad759ef 
…-or-edit-existing-rollup-job

* 'master' of github.com:elastic/kibana: (67 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/doc_value…
b366497 
…s_autocomplete

* 'master' of github.com:elastic/kibana: (189 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team test_infra v7.2.2 v7.3.1 v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @jbudz @dmlemeshko