Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Prevent whitespace wrapping of doc table header #52861

Merged

Conversation

kertal
Copy link
Member

@kertal kertal commented Dec 12, 2019

Summary

Improves legacy doc table whitespace wrapping used in Discover and Dashboard. Will be redundant with #51531, but since it's a pretty simple fix, and looks much better this way, let's improve it a bit earlier.

Before:

Bildschirmfoto 2020-05-07 um 21 34 22

After:

Bildschirmfoto 2020-05-07 um 21 35 10

Fixes: #56529

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented Jan 8, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@kertal kertal self-assigned this Jan 31, 2020
@kertal kertal added the Feature:Discover Discover Application label Jan 31, 2020
@kertal
Copy link
Member Author

kertal commented Mar 23, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@kertal
Copy link
Member Author

kertal commented May 7, 2020

@elasticmachine merge upstream

@kertal kertal added release_note:fix v7.9.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal marked this pull request as ready for review May 7, 2020 19:48
@kertal kertal requested a review from a team as a code owner May 7, 2020 19:48
@kertal
Copy link
Member Author

kertal commented May 7, 2020

@elasticmachine merge upstream

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in browser. This works. Could cause problems eventually with long field names, but since any field should not contain spaces anyway, i think this would be the preferred functionality.

Co-authored-by: Dave Snider <dave.snider@gmail.com>
@kertal
Copy link
Member Author

kertal commented May 8, 2020

Tested in browser. This works. Could cause problems eventually with long field names, but since any field should not contain spaces anyway, i think this would be the preferred functionality.

Yes, there's a problem with very long fields that define the width of the column here, but that's not that easy to fix, so it's up to our DataGrid then.

@kertal kertal requested a review from stratoula May 8, 2020 07:35
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on chrome, safari and firefox and sees legit

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal requested a review from snide May 8, 2020 10:47
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Didn't test this, but SASS LGTM from @snide's input

@kertal kertal merged commit 3a6c1ce into elastic:master May 8, 2020
kertal added a commit to kertal/kibana that referenced this pull request May 8, 2020
…2861)

Co-authored-by: Dave Snider <dave.snider@gmail.com>
kertal added a commit that referenced this pull request May 8, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 11, 2020
* master: (58 commits)
  [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628)
  fix double flyouts in add panel flow (elastic#65861)
  Point 7.x to 7.9.0 in .backportrc.json
  Mount ui/new_platform applications in same div structure as Core (elastic#63930)
  [Uptime] Settings threshold validation (elastic#65454)
  Fix edit alert flyout to update initialAlert after edit (elastic#65359)
  Fix anomalies display on focused APM service map (elastic#65882)
  [SIEM][Detection Engine] Increases the template limit for ECS mappings
  [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851)
  [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579)
  [ML] Add job timing stats to anomaly jobs (elastic#65696)
  restore index pattern management data-test-subj's (elastic#64697)
  [Discover] Prevent whitespace wrapping of doc table header (elastic#52861)
  [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789)
  Skipping failing tests. elastic#65867 elastic#65866 elastic#65865
  [Discover] Deangularize the hits counter and create a react component (elastic#65631)
  Tsvb less update (elastic#65467)
  [TSVB] Remove remaining lodash.set usage (elastic#65846)
  [Uptime] Add `a11y` tests (elastic#65514)
  [Uptime] Enable loading on monitor list (elastic#65670)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field names on different level on version
6 participants