-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Enable loading on monitor list #65670
Merged
shahzad31
merged 3 commits into
elastic:master
from
shahzad31:enable-monitor-list-loading
May 8, 2020
Merged
[Uptime] Enable loading on monitor list #65670
shahzad31
merged 3 commits into
elastic:master
from
shahzad31:enable-monitor-list-loading
May 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
label
May 7, 2020
Pinging @elastic/uptime (Team:uptime) |
shahzad31
added
release_note:skip
Skip the PR/issue when compiling release notes
v7.8.0
v7.9.0
v8.0.0
labels
May 7, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
andrewvc
approved these changes
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 11, 2020
* master: (58 commits) [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628) fix double flyouts in add panel flow (elastic#65861) Point 7.x to 7.9.0 in .backportrc.json Mount ui/new_platform applications in same div structure as Core (elastic#63930) [Uptime] Settings threshold validation (elastic#65454) Fix edit alert flyout to update initialAlert after edit (elastic#65359) Fix anomalies display on focused APM service map (elastic#65882) [SIEM][Detection Engine] Increases the template limit for ECS mappings [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851) [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579) [ML] Add job timing stats to anomaly jobs (elastic#65696) restore index pattern management data-test-subj's (elastic#64697) [Discover] Prevent whitespace wrapping of doc table header (elastic#52861) [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789) Skipping failing tests. elastic#65867 elastic#65866 elastic#65865 [Discover] Deangularize the hits counter and create a react component (elastic#65631) Tsvb less update (elastic#65467) [TSVB] Remove remaining lodash.set usage (elastic#65846) [Uptime] Add `a11y` tests (elastic#65514) [Uptime] Enable loading on monitor list (elastic#65670) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
May 12, 2020
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
May 12, 2020
shahzad31
added a commit
that referenced
this pull request
May 12, 2020
shahzad31
added a commit
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.8.0
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initial issue described in elastic/eui#2393 is no longer reproducible, seems like basic table got refactored so i can't reproduce the issue, so enable loading on monitor list.
Also enabled loading on cert list.