-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Remove service map fullscreen control #56351
Conversation
78b42a1
to
d82fb67
Compare
Add center button for service map. The fullscreen button is still there until elastic#56351 is merged. Add fit and padding to the layout animation. Make the node labels wider so they aren't cut off.
Add center button for service map. The fullscreen button is still there until #56351 is merged. Add fit and padding to the layout animation. Make the node labels wider so they aren't cut off.
Add center button for service map. The fullscreen button is still there until elastic#56351 is merged. Add fit and padding to the layout animation. Make the node labels wider so they aren't cut off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add center button for service map. The fullscreen button is still there until elastic#56351 is merged. Add fit and padding to the layout animation. Make the node labels wider so they aren't cut off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment about newlines
@@ -13201,4 +13200,4 @@ | |||
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "フィールドを選択してください。", | |||
"xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。" | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the newline be here? same as below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should. Kibana's .editorconfig has insert_final_newline = true
and Prettier puts it there by default. If there's supposed to be an exception here it should be designated by the linter to be so.
@elasticmachine merge upstream |
merge conflict between base and head |
d82fb67
to
ddfa08b
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Fixes #56217