Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Service map center button #56434

Merged
merged 1 commit into from
Jan 30, 2020
Merged

[APM] Service map center button #56434

merged 1 commit into from
Jan 30, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Jan 30, 2020

Add center button for service map.

The fullscreen button is still there until #56351 is merged.

Add fit and padding to the layout animation.

Make the node labels wider so they aren't cut off.

Fixes #56218

Add center button for service map.

The fullscreen button is still there until elastic#56351 is merged.

Add fit and padding to the layout animation.

Make the node labels wider so they aren't cut off.
@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 apm:service-maps Service Map feature in APM labels Jan 30, 2020
@smith smith requested a review from a team as a code owner January 30, 2020 19:37
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 81f3fbb into elastic:master Jan 30, 2020
@smith smith deleted the nls/fit-button branch January 30, 2020 21:06
smith added a commit to smith/kibana that referenced this pull request Jan 31, 2020
Add center button for service map.

The fullscreen button is still there until elastic#56351 is merged.

Add fit and padding to the layout animation.

Make the node labels wider so they aren't cut off.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 31, 2020
* master: (53 commits)
  Fix setting filters without $store value (elastic#56304)
  kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316)
  [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935)
  [reporting] remove a legacy cross-plugin import (elastic#56354)
  [DOCS] Updates example in Timelion doc (elastic#56444)
  [APM] Service map center button (elastic#56434)
  [skip-ci] Add example for migrating pre-handlers (elastic#56080)
  [ML] Fix Data Visualizer responsive layout  (elastic#56372)
  Add missing docker settings (elastic#56411)
  [Endpoint] Add Endpoint Details route (elastic#55746)
  chore(NA): delete data/optimize with kbn clean (elastic#55890)
  System index templates can't be edited (elastic#55229)
  Sync badge (elastic#55113)
  Only fire appState changes when there is a change (elastic#56183)
  Import appropriate files to setup plugin system at the correct time (elastic#55956)
  [Monitoring] Change all configs to `monitoring.*` (elastic#56215)
  [ML] conditional rison encoding for query params (elastic#56380)
  Move tsvb server to new platform (elastic#55310)
  exclude tutorial resources from code ownership (elastic#55987)
  [Watcher] Follow up on flaky functional test (elastic#56384)
  ...
smith added a commit that referenced this pull request Jan 31, 2020
Add center button for service map.

The fullscreen button is still there until #56351 is merged.

Add fit and padding to the layout animation.

Make the node labels wider so they aren't cut off.
jfsiii pushed a commit to jfsiii/kibana that referenced this pull request Feb 4, 2020
Add center button for service map.

The fullscreen button is still there until elastic#56351 is merged.

Add fit and padding to the layout animation.

Make the node labels wider so they aren't cut off.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:service-maps Service Map feature in APM release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Service Maps: "Fit to window" option to map controls
3 participants