Converted terms_other_bucket_helper to TS. Migrated tests to jest. #58143

VladLasitsa · 2020-02-20T16:13:13Z

Closes: #57396

Summary

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.js

convert to TS
convert test file to TS/Jest
add tests for any missing cases you find along the way

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

kibanamachine · 2020-02-20T16:13:15Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

cla-checker-service · 2020-02-20T16:13:17Z

Author of the following commits did not sign a Contributor Agreement:
563d735

Please, read and sign the above mentioned agreement if you want to contribute to this project

VladLasitsa · 2020-02-21T10:01:15Z

@elasticmachine merge upstream

…Convert_to_TS_Jest

cla-checker-service · 2020-02-21T10:01:28Z

💚 CLA has been signed

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.test.ts

VladLasitsa · 2020-02-21T14:14:23Z

@elasticmachine merge upstream

…Convert_to_TS_Jest

VladLasitsa · 2020-02-21T14:17:18Z

@elasticmachine merge upstream

…Convert_to_TS_Jest

alexwizp · 2020-02-21T16:03:03Z

@elasticmachine merge upstream

…Convert_to_TS_Jest

brianseeders · 2020-02-21T16:28:17Z

cla/check

jbudz · 2020-02-21T16:56:32Z

@VladLasitsa can you go through the CLA signing process using the email in your git commit(maybe again - sorry); the cla check only checks two lists currently, signings through https://www.elastic.co/contributor-agreement or if the github account is in the elastic org

jbudz · 2020-02-24T14:00:43Z

cla/check

VladLasitsa · 2020-02-24T16:18:20Z

cla/check

VladLasitsa · 2020-02-25T07:50:45Z

@elasticmachine merge upstream

…Convert_to_TS_Jest

alexwizp · 2020-02-25T08:47:48Z

retest

VladLasitsa · 2020-02-25T15:38:25Z

jenkins test this please

VladLasitsa · 2020-02-26T09:04:44Z

@elasticmachine merge upstream

…Convert_to_TS_Jest

elasticmachine · 2020-02-26T14:36:09Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

VladLasitsa · 2020-02-26T14:36:43Z

@elasticmachine merge upstream

…Convert_to_TS_Jest

ppisljar

some initial questions

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.ts

ppisljar · 2020-02-26T14:53:09Z

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.test.ts

+      params: {
+        field: {
+          name: 'machine.os.raw',
+          indexPattern,


why are indexPattern and filterable now passed in ? (whole field is an object, where before it was a string)

I don't know how it worked before. Nevertheless, we can have a string as a field but in this case, we should modify mock of IndexPattern because there are several tests that use aggconfig with two fields. From my point of view more simple to use an object as a field.

VladLasitsa · 2020-02-27T07:55:30Z

@elasticmachine merge upstream

…Convert_to_TS_Jest

lukeelmers

Will continue reviewing this in more detail tomorrow, added a couple small comments so far

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.ts

…rms_other_bucket_helper]_Convert_to_TS_Jest

lukeelmers

Okay, took another look and tested locally (chrome), and nothing seems amiss.

LGTM, thanks @VladLasitsa!

alexwizp · 2020-03-02T07:54:16Z

@elasticmachine merge upstream

…Convert_to_TS_Jest

kibanamachine · 2020-03-02T12:42:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 20d5ba6

History

💔 Build #29986 failed dd5e8e2
💚 Build #29697 succeeded 0dc7b1a
💚 Build #29376 succeeded b6c5afa
💚 Build #29133 succeeded 1982244
💚 Build #29058 succeeded 5477101

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…lastic#58143) * Converted terms_other_bucket_helper to TS. Migrated tests to jest. * Fixed some remarks * fix PR comments * Fixed tests * Fixed types Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

…58143) (#59031) * Converted terms_other_bucket_helper to TS. Migrated tests to jest. * Fixed some remarks * fix PR comments * Fixed tests * Fixed types Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

…lastic#58143) * Converted terms_other_bucket_helper to TS. Migrated tests to jest. * Fixed some remarks * fix PR comments * Fixed tests * Fixed types Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

Converted terms_other_bucket_helper to TS. Migrated tests to jest.

563d735

VladLasitsa requested a review from alexwizp February 20, 2020 16:13

Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…

3b9f3ef

…Convert_to_TS_Jest

alexwizp reviewed Feb 21, 2020

View reviewed changes

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.test.ts Outdated Show resolved Hide resolved

alexwizp reviewed Feb 21, 2020

View reviewed changes

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.test.ts Outdated Show resolved Hide resolved

alexwizp reviewed Feb 21, 2020

View reviewed changes

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.test.ts Outdated Show resolved Hide resolved

Fixed some remarks

a6977a0

Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…

cce8cf1

…Convert_to_TS_Jest

Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…

10f3120

…Convert_to_TS_Jest

Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…

6d41849

…Convert_to_TS_Jest

Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…

b161d3e

…Convert_to_TS_Jest

elastic deleted a comment from VladLasitsa Feb 25, 2020

Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…

5477101

…Convert_to_TS_Jest

VladLasitsa self-assigned this Feb 26, 2020

VladLasitsa added the Feature:NP Migration label Feb 26, 2020

VladLasitsa added v7.7.0 v8.0.0 labels Feb 26, 2020

VladLasitsa marked this pull request as ready for review February 26, 2020 14:36

VladLasitsa requested a review from a team as a code owner February 26, 2020 14:36

Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…

1982244

…Convert_to_TS_Jest

ppisljar reviewed Feb 26, 2020

View reviewed changes

Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…

b6c5afa

…Convert_to_TS_Jest

lukeelmers mentioned this pull request Feb 27, 2020

Prep agg types for new platform #57064

Merged

40 tasks

lukeelmers reviewed Feb 28, 2020

View reviewed changes

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.ts Outdated Show resolved Hide resolved

src/legacy/core_plugins/data/public/search/aggs/buckets/_terms_other_bucket_helper.ts Outdated Show resolved Hide resolved

alexwizp added 2 commits February 28, 2020 15:54

Merge remote-tracking branch 'upstream/master' into migration_aggs/te…

bec6a1b

…rms_other_bucket_helper]_Convert_to_TS_Jest

fix PR comments

0dc7b1a

alexwizp approved these changes Feb 28, 2020

View reviewed changes

lukeelmers approved these changes Feb 28, 2020

View reviewed changes

elasticmachine and others added 3 commits March 2, 2020 02:54

Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…

816306a

…Convert_to_TS_Jest

Fixed tests

dd5e8e2

Fixed types

20d5ba6

VladLasitsa merged commit b5dd99c into elastic:master Mar 2, 2020

VladLasitsa mentioned this pull request Mar 2, 2020

[7.x] Converted terms_other_bucket_helper to TS. Migrated tests to jest. (#58143) #59031

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Converted terms_other_bucket_helper to TS. Migrated tests to jest. #58143

Converted terms_other_bucket_helper to TS. Migrated tests to jest. #58143

VladLasitsa commented Feb 20, 2020 •

edited

Loading

kibanamachine commented Feb 20, 2020

cla-checker-service bot commented Feb 20, 2020

VladLasitsa commented Feb 21, 2020

cla-checker-service bot commented Feb 21, 2020 •

edited

Loading

VladLasitsa commented Feb 21, 2020

VladLasitsa commented Feb 21, 2020

alexwizp commented Feb 21, 2020

brianseeders commented Feb 21, 2020

jbudz commented Feb 21, 2020

jbudz commented Feb 24, 2020

VladLasitsa commented Feb 24, 2020

VladLasitsa commented Feb 25, 2020

alexwizp commented Feb 25, 2020

VladLasitsa commented Feb 25, 2020

VladLasitsa commented Feb 26, 2020

elasticmachine commented Feb 26, 2020

VladLasitsa commented Feb 26, 2020

ppisljar left a comment

ppisljar Feb 26, 2020

VladLasitsa Feb 26, 2020 •

edited

Loading

VladLasitsa commented Feb 27, 2020

lukeelmers left a comment

lukeelmers left a comment

alexwizp commented Mar 2, 2020

kibanamachine commented Mar 2, 2020

Converted terms_other_bucket_helper to TS. Migrated tests to jest. #58143

Converted terms_other_bucket_helper to TS. Migrated tests to jest. #58143

Conversation

VladLasitsa commented Feb 20, 2020 • edited Loading

Summary

Checklist

For maintainers

kibanamachine commented Feb 20, 2020

cla-checker-service bot commented Feb 20, 2020

VladLasitsa commented Feb 21, 2020

cla-checker-service bot commented Feb 21, 2020 • edited Loading

VladLasitsa commented Feb 21, 2020

VladLasitsa commented Feb 21, 2020

alexwizp commented Feb 21, 2020

brianseeders commented Feb 21, 2020

jbudz commented Feb 21, 2020

jbudz commented Feb 24, 2020

VladLasitsa commented Feb 24, 2020

VladLasitsa commented Feb 25, 2020

alexwizp commented Feb 25, 2020

VladLasitsa commented Feb 25, 2020

VladLasitsa commented Feb 26, 2020

elasticmachine commented Feb 26, 2020

VladLasitsa commented Feb 26, 2020

ppisljar left a comment

Choose a reason for hiding this comment

ppisljar Feb 26, 2020

Choose a reason for hiding this comment

VladLasitsa Feb 26, 2020 • edited Loading

Choose a reason for hiding this comment

VladLasitsa commented Feb 27, 2020

lukeelmers left a comment

Choose a reason for hiding this comment

lukeelmers left a comment

Choose a reason for hiding this comment

alexwizp commented Mar 2, 2020

kibanamachine commented Mar 2, 2020

💚 Build Succeeded

History

VladLasitsa commented Feb 20, 2020 •

edited

Loading

cla-checker-service bot commented Feb 21, 2020 •

edited

Loading

VladLasitsa Feb 26, 2020 •

edited

Loading