-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted terms_other_bucket_helper to TS. Migrated tests to jest. #58143
Merged
VladLasitsa
merged 15 commits into
elastic:master
from
VladLasitsa:migration_aggs/terms_other_bucket_helper]_Convert_to_TS_Jest
Mar 2, 2020
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
563d735
Converted terms_other_bucket_helper to TS. Migrated tests to jest.
VladLasitsa 3b9f3ef
Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…
elasticmachine a6977a0
Fixed some remarks
VladLasitsa cce8cf1
Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…
elasticmachine 10f3120
Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…
elasticmachine 6d41849
Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…
elasticmachine b161d3e
Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…
elasticmachine 5477101
Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…
elasticmachine 1982244
Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…
elasticmachine b6c5afa
Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…
elasticmachine bec6a1b
Merge remote-tracking branch 'upstream/master' into migration_aggs/te…
alexwizp 0dc7b1a
fix PR comments
alexwizp 816306a
Merge branch 'master' into migration_aggs/terms_other_bucket_helper]_…
elasticmachine dd5e8e2
Fixed tests
VladLasitsa 20d5ba6
Fixed types
VladLasitsa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are indexPattern and filterable now passed in ? (whole field is an object, where before it was a string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how it worked before. Nevertheless, we can have a string as a field but in this case, we should modify mock of IndexPattern because there are several tests that use aggconfig with two fields. From my point of view more simple to use an object as a field.