TSVB: Add validation support for legacy filter values #58436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:TSVB
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
approved these changes
Mar 3, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
Merging this, x-pack jests are not actually failing - this is a minor CI issue (more info here #59086) |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Mar 3, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Mar 3, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Mar 3, 2020
flash1293
added a commit
that referenced
this pull request
Mar 3, 2020
flash1293
added a commit
that referenced
this pull request
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58340
A filter in a series can also be an empty string because the migration didn't catch this specific case: https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/kibana/migrations/migrations.js#L253
Eventually we should run an additional migration for this, but for now let's just collect it in the validation so it won't get forgotten and fix all of these little problems in a single migration.
It also fixes gauge color and percentiles aggregation validation errors