-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Comment out Jest hooks in skipped blocks #59086
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
retest
|
@elasticmachine merge upstream |
Jest will run the hooks regardless of if they are skipped. Tests skipped in elastic@61c9dc4 and elastic@420ded8 were still resulting in build failures due to the beforeEach failing. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
4f4cd0b
to
f85dd81
Compare
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/copy_to_space·ts.spaces api with security copy to spaces rbac user with all at space from the space_1 space "before each" hook in "rbac user with all at space from the space_1 space"Standard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/copy_to_space·ts.spaces api with security copy to spaces rbac user with all at space from the space_1 space "after each" hook for "should return 200 when copying to space with conflicts without overwriting"Standard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/copy_to_space·ts.spaces api with security copy to spaces rbac user with all at space from the space_1 space "before each" hook in "rbac user with all at space from the space_1 space"Standard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Friendly reminder: Looks like this PR hasn’t been backported yet. |
* [test] Comment out Jest hooks in skipped blocks Jest will run the hooks regardless of if they are skipped. Tests skipped in elastic@61c9dc4 and elastic@420ded8 were still resulting in build failures due to the beforeEach failing. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Additional variables/imports no longer needed Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Skip additional flaky ingest tests Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Comment out file Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Must have one test Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* Skips failing Ingest Manager integration tests #58969 #58968 #58967 #58966 #58961 #58960 #58959 #58958 #58958 #58957 #58956 #58955 #58954 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Skips additional failing Ingest Manager integration tests #58969 #58968 #58967 #58966 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [test] Comment out Jest hooks in skipped blocks (#59086) * [test] Comment out Jest hooks in skipped blocks Jest will run the hooks regardless of if they are skipped. Tests skipped in 61c9dc4 and 420ded8 were still resulting in build failures due to the beforeEach failing. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Additional variables/imports no longer needed Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Skip additional flaky ingest tests Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Comment out file Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Must have one test Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Friendly reminder: Looks like this PR hasn’t been backported yet. |
10 similar comments
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Jest will run the hooks regardless of if they are skipped.
Tests skipped in 61c9dc4 and 420ded8 were still resulting in build failures due to the beforeEach failing.
jestjs/jest#8379