Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Adds 'Close one signal' Cypress test #60064

Merged
merged 1 commit into from
Mar 16, 2020
Merged

[SIEM] Adds 'Close one signal' Cypress test #60064

merged 1 commit into from
Mar 16, 2020

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Mar 12, 2020 •
edited
Loading

Summary

In this PR we are adding a Cypress test to check that only one signal is closed when more than one are selected.

detectionsspects (1)

In order to test it these actions are performed:

  1. Open detections page
  2. Checks that the close signal bulk button is disabled
  3. Selects more than one signal
  4. Checks that the close signal bulk button is enabled
  5. Closes only the first signal
  6. Checks that there is one signal less opened
  7. Goes to closed signals
  8. Checks that there is a closed signal

Note that to make the test pass it is expected to have only opened signals. When running the tests in CI mode, this is achieved because it loads using es_arhiver a set of data that only have open signals.

@MadameSheema MadameSheema self-assigned this Mar 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Mar 16, 2020
@MadameSheema MadameSheema marked this pull request as ready for review March 16, 2020 11:48
FrankHassanabad
FrankHassanabad approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does what it describes. Appreciate the small concentrated pull requests. Makes reviewing things very quick and easy. It also makes it really nice to upgrade my branches these are merged and I will know if I have a failure where to look really quickly.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit a946adb into elastic:master Mar 16, 2020
@MadameSheema MadameSheema deleted the close-one-signal branch March 16, 2020 12:01
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 16, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
5d3a7ef 
* master:
  [Step 1][App Arch] Saved object migrations from kibana plugin to new platform  (elastic#59044)
  adds new test (elastic#60064)
  [Uptime] Index Status API to Rest (elastic#59657)
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Mar 16, 2020
@MadameSheema
adds new test (elastic#60064)
b2a1cef
@MadameSheema MadameSheema mentioned this pull request Mar 16, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 16, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
7cc50e3 
* master: (40 commits)
  skips 'config_open.ts' files from linter check (elastic#60248)
  [Searchprofiler] Spacing between rendered shards (elastic#60238)
  Add UiSettings validation & Kibana default route redirection (elastic#59694)
  [SIEM][CASE] Change configuration button (elastic#60229)
  [Step 1][App Arch] Saved object migrations from kibana plugin to new platform  (elastic#59044)
  adds new test (elastic#60064)
  [Uptime] Index Status API to Rest (elastic#59657)
  [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950)
  [NP] Graph migration (elastic#59409)
  [ML] Clone analytics job  (elastic#59791)
  Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202)
  Handle improperly defined Watcher Logging Action text parameter. (elastic#60169)
  Move select range trigger to uiActions (elastic#60168)
  [SIEM][CASES] Configure cases: Final (elastic#59358)
  Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153)
  [siem/cypress] update junit filename to be picked up by runbld (elastic#60156)
  OSS logic added to test environment  (elastic#60134)
  Move canvas setup into app mount (elastic#59926)
  enable triggers_actions_ui plugin by default (elastic#60137)
  Expose Elasticsearch from start and deprecate from setup (elastic#59886)
  ...
MadameSheema added a commit that referenced this pull request Mar 16, 2020
@MadameSheema
adds new test (#60064) (#60268)
0500350
@spalger spalger mentioned this pull request Mar 16, 2020
Closed
spalger pushed a commit that referenced this pull request Mar 16, 2020
Revert "adds new test (#60064)"
1763cef 
This reverts commit a946adb.
spalger added a commit that referenced this pull request Mar 16, 2020
@spalger
Revert "adds new test (#60064)"
4a8fd0a 
This reverts commit a946adb.
spalger added a commit that referenced this pull request Mar 16, 2020
@spalger
Revert "adds new test (#60064) (#60268)"
12ed61c 
This reverts commit 0500350.
@spalger
Copy link
Contributor

spalger commented Mar 16, 2020

#60317 (comment)

gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 17, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
ff11eb0 
* master: (30 commits)
  [TSVB] fix text color when using custom background color (elastic#60261)
  Fix import to timefilter from in TSVB (elastic#60296)
  [NP] Get rid of usage redirectWhenMissing service (elastic#59777)
  [SIEM] Fix Timeline footer styling (elastic#59587)
  [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249)
  Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235)
  resolves elastic#58905 (elastic#60120)
  Added variables button for text fields in Pagerduty component. (elastic#60189)
  adds test that action vars are rendered for alert action parms (elastic#60310)
  Closes 59786 by removing the update toast (elastic#60172)
  [EPM] Packages list tabs (elastic#60167)
  Added message variables button for Webhook body form field (elastic#60174)
  Revert "adds new test (elastic#60064)"
  [Maps] move MapSavedObject type out of telemetry (elastic#60127)
  [Reporting] Fix error handling for job handler in route (elastic#60161)
  [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206)
  EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218)
  Migrate dual validated range (elastic#59689)
  Embeddable triggers (elastic#58440)
  [Endpoint] Sample data generator CLI script (elastic#59952)
  ...
MadameSheema added a commit that referenced this pull request Mar 17, 2020
@MadameSheema
Revert "adds new test (#60064)"
5fbc5f0 
This reverts commit a946adb.
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Mar 17, 2020
@MadameSheema
Revert "Revert "adds new test (elastic#60064)""
3453b77 
This reverts commit 4a8fd0a.
@MadameSheema MadameSheema mentioned this pull request Mar 17, 2020
Merged
MadameSheema added a commit that referenced this pull request Mar 17, 2020
@MadameSheema
[SIEM] Adds 'Closes one signal when more than one opened signals are …
79b0454 
…selected' test again (#60380)

* Revert "Revert "adds new test (#60064)""

This reverts commit 4a8fd0a.

* waits for having 25 signals displayed
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Mar 17, 2020
@MadameSheema
[SIEM] Adds 'Closes one signal when more than one opened signals are …
63b339a 
…selected' test again (elastic#60380)

* Revert "Revert "adds new test (elastic#60064)""

This reverts commit 4a8fd0a.

* waits for having 25 signals displayed
MadameSheema added a commit that referenced this pull request Mar 18, 2020
@MadameSheema @elasticmachine
[SIEM] Adds 'Closes one signal when more than one opened signals are …
b9e4e6e 
…selected' test again (#60380) (#60417)

* Revert "Revert "adds new test (#60064)""

This reverts commit 4a8fd0a.

* waits for having 25 signals displayed

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@rylnd rylnd Awaiting requested review from rylnd

@spong spong Awaiting requested review from spong

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@dhurley14 dhurley14 Awaiting requested review from dhurley14

@yctercero yctercero Awaiting requested review from yctercero

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes reverted Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @kibanamachine @spalger @FrankHassanabad