Give better stack traces for Unhandled Promise Rejection warnings #60235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
watson
added
the
release_note:skip
pgayvallet
reviewed
Mar 16, 2020
Comment on lines
+42
to
+49
| process.on('unhandledRejection', function(reason) { | ||
| console.error('Unhandled Promise rejection detected:'); | ||
| console.error(); | ||
| console.error(reason); | ||
| console.error(); | ||
| console.error('Terminating process...'); | ||
| process.exit(1); | ||
| }); |
There was a problem hiding this comment.
Isn't this already catched by the warning event?
Node.js process-warning detected:
[2020-03-16T08:30:26.360Z]
[2020-03-16T08:30:26.360Z] UnhandledPromiseRejectionWarning: [object Object]
[2020-03-16T08:30:26.360Z] at emitWarning (internal/process/promises.js:99:15)
[2020-03-16T08:30:26.360Z] at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[2020-03-16T08:30:26.360Z] at process._tickCallback (internal/process/next_tick.js:69:34)
[2020-03-16T08:30:26.360Z]
[2020-03-16T08:30:26.360Z] Terminating process...
[2020-03-16T08:30:26.360Z] Fatal error: jest exited with code 1�
Or will the reason catched by the unhandledRejection contains more info than what is catched by the warning handler?
There was a problem hiding this comment.
The stack trace available for the unhandled exception is just pointing back to a next-tick frame which doesn't show any of the user-land code. This makes the stack trace unusable and the reader can't see which Promise was not handled correctly.
By implementing an unhandledRejection listener we get access to the rejection reason, which hopefully always is an Error object with its own stack trace. We can use this stack trace to guide the developer towards the location where the Promise rejection wasn't handled.
There was a problem hiding this comment.
That was the question :) great then.
💚 Build SucceededTo update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Mar 17, 2020
watson
added a commit
to watson/kibana
that referenced
this pull request
Mar 17, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 17, 2020
* master: (30 commits) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) [SIEM] Fix Timeline footer styling (elastic#59587) [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249) Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235) resolves elastic#58905 (elastic#60120) Added variables button for text fields in Pagerduty component. (elastic#60189) adds test that action vars are rendered for alert action parms (elastic#60310) Closes 59786 by removing the update toast (elastic#60172) [EPM] Packages list tabs (elastic#60167) Added message variables button for Webhook body form field (elastic#60174) Revert "adds new test (elastic#60064)" [Maps] move MapSavedObject type out of telemetry (elastic#60127) [Reporting] Fix error handling for job handler in route (elastic#60161) [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206) EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218) Migrate dual validated range (elastic#59689) Embeddable triggers (elastic#58440) [Endpoint] Sample data generator CLI script (elastic#59952) ...
watson
added a commit
that referenced
this pull request
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specialized warning listener will only be in effect during development and CI. Under normal production operation where the
--no-warningsflag is used, we'll not attach theunhandledRejectionlistener.