Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add callout to inform users of high cardinality in unique transaction names #67610

Closed

Conversation

formgeist
Copy link
Contributor

@formgeist formgeist commented May 28, 2020

Summary

Related to #67273. This involves only the design and copy of the callout. We'd need to set up the proper functionalities to display this only when we're detecting an explosion in transaction names, as described in the original issue.

Screenshot 2020-05-28 at 13 26 46

We're looking to create an agent-agnostic documentation article that we can link to enable the user to fix their issues.

Tasks

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Showing a callout to inform the user we have detected a high cardinality in unique transaction names and enabling them how to fix it.
@formgeist formgeist added the Team:APM All issues that need APM UI Team support label May 28, 2020
@formgeist formgeist self-assigned this May 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

Thanks for starting this @formgeist. Looks great.

@smith
Copy link
Contributor

smith commented May 28, 2020

@nehaduggal mentioned in our meeting that this should using danger styles since it can be a big problem and hide many transactions.

@formgeist
Copy link
Contributor Author

@smith @nehaduggal Updated to use the danger callout type instead.

Screenshot 2020-05-29 at 15 00 04

@bmorelli25 Maybe you have a minute to help me update the initial copy in the callout to fit with your documentation article? I wrote it just as a quick placeholder. TY!

@nehaduggal
Copy link

Love it!

For the copy can we add explicitly that number of unique transaction names detected exceeds the configured setting so the user is only seeing subset of all the reported transactions.

@bmorelli25
Copy link
Member

Thanks for the ping. Gail and I bounced some ideas off of each other. Here are a few options we came up with. Any feedback is welcome.


This view shows a subset of reported transactions
The number of unique transaction names exceeds the configured value. Try reconfiguring your agents to group similar transactions. Learn more in the docs.


Too many unique transaction names
This view cannot display all transaction groups. You may need to reconfigure your agents to group similar transactions. Learn more in the docs.


In the docs we can then mention that the number of unique transaction names exceeds the value configured in xpack.apm.ui.transactionGroupBucketSize, and explain how to increase that. We can also link to Agent documentation for fixing this problem.

@sorenlouv
Copy link
Member

sorenlouv commented May 30, 2020

We can access the configured limit so we could write something like:


This view shows a subset of reported transactions
The number of unique transaction names exceeds the configured value of 200. Try reconfiguring your agents to group similar transactions. Learn more in the docs.


I know we show the configuration name in the docs but I think it would be useful to also show it directly in the warning message:


This view shows a subset of reported transactions
The number of unique transaction names exceeds the configured value of 20. Try reconfiguring your agents to group similar transactions or increase the value ofxpack.apm.ui.transactionGroupBucketSize. Learn more in the docs.


@bmorelli25
Copy link
Member

This view shows a subset of reported transactions
The number of unique transaction names exceeds the configured value of 200. Try reconfiguring your agents to group similar transactions or increase the value of xpack.apm.ui.transactionGroupBucketSize. Learn more in the docs.

Looks great.

@formgeist
Copy link
Contributor Author

Great teamwork 👏 I've updated the copy and styling to match the suggested messaging. I suppose next step is for someone to make this real and read the configuration and change the link once the docs article is ready.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv
Copy link
Member

replaced by #69112

@sorenlouv sorenlouv closed this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants