[APM] Add callout to inform users of high cardinality in unique transaction names #69112

sorenlouv · 2020-06-13T15:28:48Z

Blocked by #67691

Related to #67273. This involves only the design and copy of the callout. We'd need to set up the proper functionalities to display this only when we're detecting an explosion in transaction names, as described in the original issue.

We're looking to create an agent-agnostic documentation article that we can link to enable the user to fix their issues.

Tasks

Show callout and message with link to related docs article
Read the configuration from the agent remote config to indicate the value set
Update the docs article link once it's ready [docs] apm:Add documentation for reducing the number of unique transaction names #67691

elasticmachine · 2020-06-13T15:28:52Z

Pinging @elastic/apm-ui (Team:apm)

sorenlouv · 2020-06-13T18:27:13Z

retest

sorenlouv · 2020-06-14T21:43:25Z

retest

Showing a callout to inform the user we have detected a high cardinality in unique transaction names and enabling them how to fix it.

sorenlouv · 2020-06-16T08:46:26Z

@elasticmachine merge upstream

cauemarcondes · 2020-06-16T12:43:24Z

x-pack/plugins/apm/public/components/app/TransactionOverview/index.tsx

+                  <EuiCode>
+                    xpack.apm.ui.transactionGroupBucketSize
+                  </EuiCode>.{' '}
+                  <EuiLink href="#">Learn more in the docs.</EuiLink>.


I think we should add the docs link instead of #.

oooh, good catch!

I guess still waiting for #67691

cauemarcondes · 2020-06-16T12:44:36Z

x-pack/plugins/apm/public/components/app/TransactionOverview/index.tsx

+                iconType="alert"
+              >
+                <p>
+                  The number of unique transaction names exceeds the configured


Shouldn't we translate this text too?

we should. good catch

cauemarcondes

LGTM. Just a few nits

x-pack/plugins/apm/public/components/app/TransactionOverview/index.tsx

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

sorenlouv · 2020-06-25T08:34:15Z

@elasticmachine merge upstream

…nique-transaction-names

kibanamachine · 2020-06-25T16:25:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2bc7fc0

Build metrics

page load asset size

beta

id	value	diff	baseline
/bundles/app/core/bootstrap.js	-	-13.8KB	13.8KB
/bundles/core/core.entry.js	-	-1.1MB	1.1MB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.@elastic.js	-	-4.0MB	4.0MB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.css	-	-183.7KB	183.7KB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js	-	-4.6MB	4.6MB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.v7.light.css	-	-511.3KB	511.3KB
/bundles/light_theme.style.css	-	-95.9KB	95.9KB
/bundles/plugin/advancedSettings/advancedSettings.plugin.js	-	-941.3KB	941.3KB
/bundles/plugin/alerts/alerts.plugin.js	-	-89.5KB	89.5KB
/bundles/plugin/apm/apm.plugin.js	-	-215.2KB	215.2KB
/bundles/plugin/apmOss/apmOss.plugin.js	-	-4.2KB	4.2KB
/bundles/plugin/beats_management/beats_management.plugin.js	-	-522.9KB	522.9KB
/bundles/plugin/bfetch/bfetch.plugin.js	-	-28.7KB	28.7KB
/bundles/plugin/canvas/canvas.plugin.js	-	-2.0MB	2.0MB
/bundles/plugin/charts/charts.plugin.js	-	-833.9KB	833.9KB
/bundles/plugin/cloud/cloud.plugin.js	-	-6.3KB	6.3KB
/bundles/plugin/console/console.plugin.js	-	-28.0KB	28.0KB
/bundles/plugin/crossClusterReplication/crossClusterReplication.plugin.js	-	-152.3KB	152.3KB
/bundles/plugin/dashboard/dashboard.plugin.js	-	-634.0KB	634.0KB
/bundles/plugin/dashboardEnhanced/dashboardEnhanced.plugin.js	-	-143.5KB	143.5KB
/bundles/plugin/dashboardMode/dashboardMode.plugin.js	-	-109.3KB	109.3KB
/bundles/plugin/data/data.plugin.js	-	-1.3MB	1.3MB
/bundles/plugin/dataEnhanced/dataEnhanced.plugin.js	-	-138.1KB	138.1KB
/bundles/plugin/devTools/devTools.plugin.js	-	-123.9KB	123.9KB
/bundles/plugin/discover/discover.plugin.js	-	-221.1KB	221.1KB
/bundles/plugin/discoverEnhanced/discoverEnhanced.plugin.js	-	-13.8KB	13.8KB
/bundles/plugin/embeddable/embeddable.plugin.js	-	-387.2KB	387.2KB
/bundles/plugin/embeddableEnhanced/embeddableEnhanced.plugin.js	-	-26.3KB	26.3KB
/bundles/plugin/esUiShared/esUiShared.plugin.js	-	-927.8KB	927.8KB
/bundles/plugin/expressions/expressions.plugin.js	-	-314.9KB	314.9KB
/bundles/plugin/features/features.plugin.js	-	-13.4KB	13.4KB
/bundles/plugin/fileUpload/fileUpload.plugin.js	-	-688.0KB	688.0KB
/bundles/plugin/globalSearch/globalSearch.plugin.js	-	-29.0KB	29.0KB
/bundles/plugin/graph/graph.plugin.js	-	-15.3KB	15.3KB
/bundles/plugin/grokdebugger/grokdebugger.plugin.js	-	-11.2KB	11.2KB
/bundles/plugin/home/home.plugin.js	-	-24.6KB	24.6KB
/bundles/plugin/indexLifecycleManagement/indexLifecycleManagement.plugin.js	-	-184.2KB	184.2KB
/bundles/plugin/indexManagement/indexManagement.plugin.js	-	-201.7KB	201.7KB
/bundles/plugin/indexPatternManagement/indexPatternManagement.plugin.js	-	-137.3KB	137.3KB
/bundles/plugin/infra/infra.plugin.js	-	-92.9KB	92.9KB
/bundles/plugin/ingestPipelines/ingestPipelines.plugin.js	-	-30.3KB	30.3KB
/bundles/plugin/inputControlVis/inputControlVis.plugin.js	-	-258.9KB	258.9KB
/bundles/plugin/inspector/inspector.plugin.js	-	-238.3KB	238.3KB
/bundles/plugin/kibanaLegacy/kibanaLegacy.plugin.js	-	-174.7KB	174.7KB
/bundles/plugin/kibanaReact/kibanaReact.plugin.js	-	-575.3KB	575.3KB
/bundles/plugin/kibanaUtils/kibanaUtils.plugin.js	-	-432.8KB	432.8KB
/bundles/plugin/lens/lens.plugin.js	-	-746.9KB	746.9KB
/bundles/plugin/licenseManagement/licenseManagement.plugin.js	-	-26.2KB	26.2KB
/bundles/plugin/licensing/licensing.plugin.js	-	-21.6KB	21.6KB
/bundles/plugin/logstash/logstash.plugin.js	-	-141.8KB	141.8KB
/bundles/plugin/management/management.plugin.js	-	-25.9KB	25.9KB
/bundles/plugin/maps/maps.plugin.js	-	-220.0KB	220.0KB
/bundles/plugin/mapsLegacy/mapsLegacy.plugin.js	-	-1.0MB	1.0MB
/bundles/plugin/mapsLegacyLicensing/mapsLegacyLicensing.plugin.js	-	-3.9KB	3.9KB
/bundles/plugin/ml/ml.plugin.js	-	-1.3MB	1.3MB
/bundles/plugin/monitoring/monitoring.plugin.js	-	-22.8KB	22.8KB
/bundles/plugin/navigation/navigation.plugin.js	-	-122.2KB	122.2KB
/bundles/plugin/newsfeed/newsfeed.plugin.js	-	-22.7KB	22.7KB
/bundles/plugin/observability/observability.plugin.js	-	-103.3KB	103.3KB
/bundles/plugin/painlessLab/painlessLab.plugin.js	-	-158.8KB	158.8KB
/bundles/plugin/regionMap/regionMap.plugin.js	-	-791.7KB	791.7KB
/bundles/plugin/remoteClusters/remoteClusters.plugin.js	-	-35.2KB	35.2KB
/bundles/plugin/reporting/reporting.plugin.js	-	-257.7KB	257.7KB
/bundles/plugin/rollup/rollup.plugin.js	-	-186.0KB	186.0KB
/bundles/plugin/savedObjects/savedObjects.plugin.js	-	-196.2KB	196.2KB
/bundles/plugin/savedObjectsManagement/savedObjectsManagement.plugin.js	-	-176.6KB	176.6KB
/bundles/plugin/searchprofiler/searchprofiler.plugin.js	-	-42.8KB	42.8KB
/bundles/plugin/security/security.plugin.js	-	-248.0KB	248.0KB
/bundles/plugin/share/share.plugin.js	-	-80.5KB	80.5KB
/bundles/plugin/snapshotRestore/snapshotRestore.plugin.js	-	-57.5KB	57.5KB
/bundles/plugin/spaces/spaces.plugin.js	-	-367.3KB	367.3KB
/bundles/plugin/statusPage/statusPage.plugin.js	-	-3.6KB	3.6KB
/bundles/plugin/telemetry/telemetry.plugin.js	-	-77.2KB	77.2KB
/bundles/plugin/telemetryManagementSection/telemetryManagementSection.plugin.js	-	-27.5KB	27.5KB
/bundles/plugin/tileMap/tileMap.plugin.js	-	-807.1KB	807.1KB
/bundles/plugin/transform/transform.plugin.js	-	-21.6KB	21.6KB
/bundles/plugin/triggers_actions_ui/triggers_actions_ui.plugin.js	-	-102.9KB	102.9KB
/bundles/plugin/uiActions/uiActions.plugin.js	-	-162.5KB	162.5KB
/bundles/plugin/uiActionsEnhanced/uiActionsEnhanced.plugin.js	-	-124.1KB	124.1KB
/bundles/plugin/upgradeAssistant/upgradeAssistant.plugin.js	-	-46.6KB	46.6KB
/bundles/plugin/uptime/uptime.plugin.js	-	-327.3KB	327.3KB
/bundles/plugin/usageCollection/usageCollection.plugin.js	-	-24.4KB	24.4KB
/bundles/plugin/visTypeMarkdown/visTypeMarkdown.plugin.js	-	-512.5KB	512.5KB
/bundles/plugin/visTypeMetric/visTypeMetric.plugin.js	-	-536.7KB	536.7KB
/bundles/plugin/visTypeTable/visTypeTable.plugin.js	-	-563.0KB	563.0KB
/bundles/plugin/visTypeTagcloud/visTypeTagcloud.plugin.js	-	-797.1KB	797.1KB
/bundles/plugin/visTypeTimelion/visTypeTimelion.plugin.js	-	-670.7KB	670.7KB
/bundles/plugin/visTypeTimeseries/visTypeTimeseries.plugin.js	-	-212.2KB	212.2KB
/bundles/plugin/visTypeVega/visTypeVega.plugin.js	-	-580.3KB	580.3KB
/bundles/plugin/visTypeVislib/visTypeVislib.plugin.js	-	-1.2MB	1.2MB
/bundles/plugin/visualizations/visualizations.plugin.js	-	-343.4KB	343.4KB
/bundles/plugin/visualize/visualize.plugin.js	-	-18.2KB	18.2KB
/bundles/plugin/watcher/watcher.plugin.js	-	-35.2KB	35.2KB
/node_modules/@kbn/ui-framework/dist/kui_light.css	-	-62.1KB	62.1KB
/translations/en.json	-	-29.0B	29.0B
/ui/fonts/inter_ui/Inter-UI-Medium.woff2	-	-92.2KB	92.2KB
/ui/fonts/inter_ui/Inter-UI-Regular.woff2	-	-86.4KB	86.4KB
total	-	-36.1MB	-

History

💔 Build #56212 failed e2396d3
💔 Build #55851 failed 19a6ebb
💔 Build #54978 failed 491676e
💚 Build #54302 succeeded 6dae0fc
💔 Build #54206 failed 2ea3755

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…action names (elastic#69112) * [APM] Add callout Showing a callout to inform the user we have detected a high cardinality in unique transaction names and enabling them how to fix it. * Changed color and icon * Updated copy and styling * Check number of returned buckets * Add translations and docs * Update docs link Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Fix tests Co-authored-by: Casper Hübertz <casper@formgeist.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

…action names (#69112) (#70153) * [APM] Add callout Showing a callout to inform the user we have detected a high cardinality in unique transaction names and enabling them how to fix it. * Changed color and icon * Updated copy and styling * Check number of returned buckets * Add translations and docs * Update docs link Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Fix tests Co-authored-by: Casper Hübertz <casper@formgeist.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> Co-authored-by: Casper Hübertz <casper@formgeist.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

cauemarcondes · 2020-07-20T11:47:23Z

tests ok:
✅ Chrome
✅ FF
✅ Safari

sorenlouv requested a review from a team as a code owner June 13, 2020 15:28

botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 13, 2020

sorenlouv added release_note:enhancement v7.9.0 labels Jun 13, 2020

sorenlouv mentioned this pull request Jun 13, 2020

[APM] Add callout to inform users of high cardinality in unique transaction names #67610

Closed

10 tasks

formgeist and others added 4 commits June 15, 2020 23:37

[APM] Add callout

5e44969

Showing a callout to inform the user we have detected a high cardinality in unique transaction names and enabling them how to fix it.

Changed color and icon

8bd6b66

Updated copy and styling

f81dc17

Check number of returned buckets

2ea3755

sorenlouv force-pushed the apm-callout-unique-transaction-names branch from 3185602 to 2ea3755 Compare June 15, 2020 21:38

Merge branch 'master' into apm-callout-unique-transaction-names

6dae0fc

cauemarcondes reviewed Jun 16, 2020

View reviewed changes

cauemarcondes approved these changes Jun 16, 2020

View reviewed changes

bmorelli25 mentioned this pull request Jun 16, 2020

[docs] apm:Add documentation for reducing the number of unique transaction names #67691

Closed

Add translations and docs

491676e

sorenlouv added the blocked label Jun 21, 2020

bmorelli25 reviewed Jun 24, 2020

View reviewed changes

x-pack/plugins/apm/public/components/app/TransactionOverview/index.tsx Outdated Show resolved Hide resolved

Update docs link

19a6ebb

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

bmorelli25 mentioned this pull request Jun 24, 2020

[APM] docs: unique transaction troubleshooting #69831

Merged

elasticmachine and others added 3 commits June 25, 2020 02:34

Merge branch 'master' into apm-callout-unique-transaction-names

e2396d3

Merge branch 'master' of github.com:elastic/kibana into apm-callout-u…

fd21494

…nique-transaction-names

Fix tests

2bc7fc0

sorenlouv merged commit 86895ef into elastic:master Jun 25, 2020

sorenlouv deleted the apm-callout-unique-transaction-names branch June 25, 2020 17:11

sorenlouv mentioned this pull request Jun 27, 2020

[7.x] [APM] Add callout to inform users of high cardinality in unique transaction names (#69112) #70153

Merged

sorenlouv added the apm:test-plan-7.9.0 Test plan for 7.9 release label Jul 16, 2020

cauemarcondes self-assigned this Jul 20, 2020

cauemarcondes added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jul 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Add callout to inform users of high cardinality in unique transaction names #69112

[APM] Add callout to inform users of high cardinality in unique transaction names #69112

sorenlouv commented Jun 13, 2020 •

edited

Loading

elasticmachine commented Jun 13, 2020

sorenlouv commented Jun 13, 2020

sorenlouv commented Jun 14, 2020

sorenlouv commented Jun 16, 2020

cauemarcondes Jun 16, 2020

sorenlouv Jun 16, 2020

formgeist Jun 17, 2020

cauemarcondes Jun 16, 2020

sorenlouv Jun 16, 2020

cauemarcondes left a comment

sorenlouv commented Jun 25, 2020

kibanamachine commented Jun 25, 2020

cauemarcondes commented Jul 20, 2020

[APM] Add callout to inform users of high cardinality in unique transaction names #69112

[APM] Add callout to inform users of high cardinality in unique transaction names #69112

Conversation

sorenlouv commented Jun 13, 2020 • edited Loading

Tasks

elasticmachine commented Jun 13, 2020

sorenlouv commented Jun 13, 2020

sorenlouv commented Jun 14, 2020

sorenlouv commented Jun 16, 2020

cauemarcondes Jun 16, 2020

Choose a reason for hiding this comment

sorenlouv Jun 16, 2020

Choose a reason for hiding this comment

formgeist Jun 17, 2020

Choose a reason for hiding this comment

cauemarcondes Jun 16, 2020

Choose a reason for hiding this comment

sorenlouv Jun 16, 2020

Choose a reason for hiding this comment

cauemarcondes left a comment

Choose a reason for hiding this comment

sorenlouv commented Jun 25, 2020

kibanamachine commented Jun 25, 2020

💚 Build Succeeded

Build metrics

page load asset size

History

cauemarcondes commented Jul 20, 2020

sorenlouv commented Jun 13, 2020 •

edited

Loading