-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Add callout to inform users of high cardinality in unique transaction names #69112
Changes from 5 commits
5e44969
8bd6b66
f81dc17
2ea3755
6dae0fc
491676e
19a6ebb
e2396d3
fd21494
2bc7fc0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,14 @@ import { | |
EuiFlexGroup, | ||
EuiFlexItem, | ||
EuiHorizontalRule, | ||
EuiCallOut, | ||
EuiLink, | ||
EuiCode, | ||
} from '@elastic/eui'; | ||
import { Location } from 'history'; | ||
import { first } from 'lodash'; | ||
import React, { useMemo } from 'react'; | ||
import { i18n } from '@kbn/i18n'; | ||
import { useTransactionList } from '../../../hooks/useTransactionList'; | ||
import { useTransactionCharts } from '../../../hooks/useTransactionCharts'; | ||
import { IUrlParams } from '../../../context/UrlParamsContext/types'; | ||
|
@@ -154,9 +158,34 @@ export function TransactionOverview() { | |
<h3>Transactions</h3> | ||
</EuiTitle> | ||
<EuiSpacer size="s" /> | ||
{!transactionListData.isAggregationAccurate && ( | ||
<EuiCallOut | ||
title={i18n.translate( | ||
'xpack.apm.transactionCardinalityWarning', | ||
{ | ||
defaultMessage: | ||
'This view shows a subset of reported transactions.', | ||
} | ||
)} | ||
color="danger" | ||
iconType="alert" | ||
> | ||
<p> | ||
The number of unique transaction names exceeds the configured | ||
value of {transactionListData.bucketSize}. Try reconfiguring | ||
your agents to group similar transactions or increase the | ||
value of | ||
<EuiCode> | ||
xpack.apm.ui.transactionGroupBucketSize | ||
</EuiCode>.{' '} | ||
<EuiLink href="#">Learn more in the docs.</EuiLink>. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should add the docs link instead of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oooh, good catch! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess still waiting for #67691 |
||
</p> | ||
</EuiCallOut> | ||
)} | ||
<EuiSpacer size="s" /> | ||
<TransactionList | ||
isLoading={transactionListStatus === 'loading'} | ||
items={transactionListData} | ||
items={transactionListData.transactionGroups} | ||
/> | ||
</EuiPanel> | ||
</EuiFlexItem> | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we translate this text too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should. good catch