Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Add maps telemetry saved object in with mappings disabled #69995

Merged

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Jun 25, 2020

Follow up to #69871. Due to how saved objects are handled in our cloud environment, we should maintain previously used saved objects but prevent their indexing.

The following changes were made:

  • The maps-telemetry saved object has been added back to the Maps app
  • mappings have been set to enabled: false

@kindsun kindsun added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Saved Objects v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.8.1 labels Jun 25, 2020
@kindsun kindsun requested a review from a team as a code owner June 25, 2020 18:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun
Copy link
Contributor Author

kindsun commented Jun 25, 2020

@elasticmachine merge upstream

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
@kindsun kindsun requested a review from rudolf June 26, 2020 15:56
@kindsun kindsun changed the title [Maps] Add maps telemetry saved object in with index: false on all fields [Maps] Add maps telemetry saved object in with mappings disbaled Jun 26, 2020
@kindsun kindsun changed the title [Maps] Add maps telemetry saved object in with mappings disbaled [Maps] Add maps telemetry saved object in with mappings disabled Jun 26, 2020
@thomasneirynck
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun merged commit 3caab36 into elastic:master Jun 30, 2020
@kindsun kindsun deleted the add-back-maps-telemetry-with-index-false branch June 30, 2020 14:04
kindsun pushed a commit to kindsun/kibana that referenced this pull request Jun 30, 2020
kindsun pushed a commit that referenced this pull request Jun 30, 2020
#69995) (#70321)

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 1, 2020
* master:
  [ML] Modifies page title to Create job (elastic#70191)
  [APM] Add API test for service maps (elastic#70185)
  [DOCS] Adds glossary to documentation (elastic#69721)
  [Usage Collection] Report nodes feature usage (elastic#70108)
  chore: improve support for mjs file extension (elastic#70186)
  [ML] Anomaly Detection: ensure  'Category examples' tab in the expanded table row can be seen (elastic#70241)
  [Maps] Add maps telemetry saved object in with mappings disabled (elastic#69995)
  Fix typo in bootstrap command (elastic#69976)
  [code coverage] ingest correct coveredFilePath for mocha (elastic#70215)
  [Dashboard] Add visualization by value to dashboard (elastic#69898)
  updates wording in Cases connectors (elastic#70298)
  [ML] Fix license subscription race condition. (elastic#70074)
  [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
…stic#69995)

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants