[ML] Modifies page title to Create job #70191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabosteve
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
1 task
| @@ -149,13 +149,13 @@ export const Page: FC<Props> = ({ jobId }) => { | |||
| {jobId === undefined && ( | |||
| <FormattedMessage | |||
| id="xpack.ml.dataframe.analytics.creationPageTitle" | |||
| defaultMessage="Create analytics job" | |||
| defaultMessage="Create data frame analytics job" | |||
There was a problem hiding this comment.
Wondering if we need the full Create data frame analytics job text here, or if just Create job is enough? Do the breadcrumbs provide sufficient context that we are creating a data frame analytics job?
In the anomaly detection jobs wizard for example, do we need it changed to Create anomaly detection job: Advanced or is it enough just to use Create job: Advanced as is used currently.
There was a problem hiding this comment.
I think it's a good point that we have two options here: a) use the full name, which is what this PR currently proposes, or (b) use the really short name and align with what we do in anomaly detection. I think both of these options are valid, the conciseness of (b) is appealing.
There was a problem hiding this comment.
Awesome! Thanks for raising the question @peteharverson and for your insight @lcawl. My vote goes to the b option, too. I modify the PR accordingly.
szabosteve
commented
Jun 30, 2020
x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/page.tsx
Outdated
Show resolved
Hide resolved
szabosteve
commented
Jun 30, 2020
x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/page.tsx
Outdated
Show resolved
Hide resolved
szabosteve
changed the title
|
@peteharverson @lcawl |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/visualize/_tsvb_time_series·ts.visualize app visual builder Time Series should open color picker, deactivate panel and clone seriesStandard OutStack TraceBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 1, 2020
* master: [ML] Modifies page title to Create job (elastic#70191) [APM] Add API test for service maps (elastic#70185) [DOCS] Adds glossary to documentation (elastic#69721) [Usage Collection] Report nodes feature usage (elastic#70108) chore: improve support for mjs file extension (elastic#70186) [ML] Anomaly Detection: ensure 'Category examples' tab in the expanded table row can be seen (elastic#70241) [Maps] Add maps telemetry saved object in with mappings disabled (elastic#69995) Fix typo in bootstrap command (elastic#69976) [code coverage] ingest correct coveredFilePath for mocha (elastic#70215) [Dashboard] Add visualization by value to dashboard (elastic#69898) updates wording in Cases connectors (elastic#70298) [ML] Fix license subscription race condition. (elastic#70074) [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
Changes Create data frame analytics job to Create job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the title of the DFA job creation page from
Create analytics jobtoCreate job.Before
After
Checklist