Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend #70270

Merged
merged 3 commits into from
Jun 30, 2020
Merged

[SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend #70270

merged 3 commits into from
Jun 30, 2020

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented Jun 29, 2020 •
edited
Loading

Summary

  • Moves querying and tests from server to common

The function we are interested using on the front end is:

export const getQueryFilter = (
  query: Query,
  language: Language,
  filters: Array<Partial<Filter>>,
  index: Index,
  lists: ExceptionListItemSchema[]
) => {

Checklist

@FrankHassanabad FrankHassanabad requested review from a team as code owners June 29, 2020 22:00
@FrankHassanabad FrankHassanabad self-assigned this Jun 29, 2020
@FrankHassanabad FrankHassanabad added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.9.0 Team:SIEM labels Jun 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

yctercero
yctercero approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for moving this over!

@FrankHassanabad FrankHassanabad changed the title [SIEM] Moved files to common for use by front and backend [SIEM] Moves getQueryFilter to common folder for use by both front and backend Jun 30, 2020
@FrankHassanabad FrankHassanabad changed the title [SIEM] Moves getQueryFilter to common folder for use by both front and backend [SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend Jun 30, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@FrankHassanabad FrankHassanabad merged commit 7144db2 into elastic:master Jun 30, 2020
@FrankHassanabad FrankHassanabad deleted the move-files-to-common branch June 30, 2020 02:44
@FrankHassanabad FrankHassanabad mentioned this pull request Jun 30, 2020
Merged
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexk307 alexk307 alexk307 approved these changes

@yctercero yctercero yctercero approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FrankHassanabad @elasticmachine @kibanamachine @alexk307 @yctercero @MindyRS