Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY SOLUTION] Rename to hosts and administration #70913

Merged
merged 10 commits into from
Jul 8, 2020
Merged

[SECURITY SOLUTION] Rename to hosts and administration #70913

merged 10 commits into from
Jul 8, 2020

Conversation

parkiino
Copy link
Contributor

@parkiino parkiino commented Jul 7, 2020 •
edited
Loading

Summary

  • Renames "Management" side navigation, breadcrumb and header tab to "Administration"
  • Renames "Endpoints" header navigation to "Hosts"
  • Renames "Endpoint Version" to "Sensor Version" in hosts (endpoints) details flyout
  • Adds an additional sub header to hosts (endpoints) and policy lists

Issue: https://github.com/elastic/endpoint-app-team/issues/526

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@parkiino parkiino marked this pull request as ready for review July 7, 2020 20:06
@parkiino parkiino requested review from a team as code owners July 7, 2020 20:06
@parkiino parkiino added Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management v7.9.0 v8.0.0 labels Jul 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

aisantos
aisantos approved these changes Jul 7, 2020
View reviewed changes
Copy link

@aisantos aisantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;

paul-tavares
paul-tavares approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some minor comments that you can address at a later time.

Than you 🏆

x-pack/plugins/security_solution/public/management/components/management_empty_state.tsx Outdated
id="xpack.securitySolution.endpoint.endpointList.noEndpointsPrompt"
defaultMessage="You have a policy, but no Endpoints are deployed!"
id="xpack.securitySolution.endpoint.hostList.noHostsPrompt"
defaultMessage="You have a policy, but no Hosts are deployed!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Hosts be capitalized? because there are other usages below where they are not, so I'm thinking we should be consistent.

Also - this is really not for the PR, but I wonder if the messaging/terminology might be confusing from an overall flow. We say "no Hosts" are deployed, but then redirect to Fleet where the word hosts is not present, but rather, you are deploying Elastic Agent. Just something for @bfishel ++ @caitlinbetz to consider.

x-pack/plugins/security_solution/public/plugin.tsx Outdated
@@ -166,7 +168,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S

core.application.register({
id: `${APP_ID}:${SecurityPageName.hosts}`,
title: 'Hosts',
title: i18n.translate('xpack.securitySolution.hostsPage.title', { defaultMessage: 'Hosts' }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have this String (and other in that you i18n'd here) defined in /app/home/translations.ts? If so, I would propose we use those here.

@parkiino
Copy link
Contributor Author

parkiino commented Jul 8, 2020

@elasticmachine merge upstream

@parkiino
Copy link
Contributor Author

parkiino commented Jul 8, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 812 +2 810

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@parkiino parkiino merged commit 9b312b2 into elastic:master Jul 8, 2020
@parkiino parkiino deleted the task/rename branch July 8, 2020 21:28
@parkiino parkiino mentioned this pull request Jul 8, 2020
Merged
parkiino added a commit to parkiino/kibana that referenced this pull request Jul 8, 2020
@parkiino
[SECURITY SOLUTION] Rename to hosts and administration (elastic#70913)
1ca7c94 
Security solution text changes to admin and hosts
parkiino added a commit that referenced this pull request Jul 9, 2020
@parkiino
[SECURITY SOLUTION] Rename to hosts and administration (#70913) (#71158)
cdf6289 
Security solution text changes to admin and hosts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 9, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
9e74773 
* master: (39 commits)
  [APM] Add warning to notify user about legacy ML jobs (elastic#71030)
  updates consumer to siem (elastic#71117)
  Index pattern creation flow - fix spelling (elastic#71192)
  [Security Solution][Endpoint] User Manifest Cleanup + Artifact Compression (elastic#70759)
  [SECURITY] Rearrange rule name's column in Alert Table (elastic#71020)
  [SECURITY] Alerts back to Detections (elastic#71142)
  [Security Solution][Exceptions Builder] - Fixes operator selection bug (elastic#71178)
  [SIEM][Detection Engine] Speeds up value list imports by enabling streaming of files.
  [APM] Update ML job ID in data telemetry tasks (elastic#71044)
  [Resolver] Remove `currentPanelView` selector (elastic#71154)
  add meta.managed to index templates (elastic#71135)
  Clarify trial subscription levels (elastic#70900)
  [Security Solution] fix panel links (elastic#71148)
  skip flaky suite (elastic#69632)
  skip suite failing ES Promotion (elastic#71018)
  [ML] DF Analytics: add results field to wizard and show regression stats (elastic#70893)
  [SIEM] update wordings (elastic#71119)
  [SECURITY SOLUTION] Rename to hosts and administration (elastic#70913)
  [ML] Improvements for urlState hook. (elastic#70576)
  Removing uptime guide (elastic#71124)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

@aisantos aisantos aisantos approved these changes

Assignees
No one assigned
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@parkiino @elasticmachine @kibanamachine @paul-tavares @aisantos