Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Rearrange rule name's column in Alert Table #71020

Merged
merged 5 commits into from
Jul 9, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Jul 7, 2020

Summary

Fix bug to let Rule name 's column to be re-arrange through drag and drop

Jul-07-2020 17-51-06

Create re-render for reference.url and event.url to be an anchor. related to https://github.com/elastic/siem-team/issues/597

@XavierM XavierM requested review from a team as code owners July 7, 2020 21:52
@XavierM XavierM added release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.9.0 v8.0.0 labels Jul 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@XavierM XavierM requested a review from cnasikas July 7, 2020 21:53
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Tested locally, rearrange the rules column, check the persistency of the timeline to the local storage, and reset the fields.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit f43f8b7 into elastic:master Jul 9, 2020
XavierM added a commit to XavierM/kibana that referenced this pull request Jul 9, 2020
* Fix bug when you move columns rule name

* reference.url and event.url will be render as an anchor

* no need to fake index just return null
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 9, 2020
* master: (39 commits)
  [APM] Add warning to notify user about legacy ML jobs (elastic#71030)
  updates consumer to siem (elastic#71117)
  Index pattern creation flow - fix spelling (elastic#71192)
  [Security Solution][Endpoint] User Manifest Cleanup + Artifact Compression (elastic#70759)
  [SECURITY] Rearrange rule name's column in Alert Table (elastic#71020)
  [SECURITY] Alerts back to Detections (elastic#71142)
  [Security Solution][Exceptions Builder] - Fixes operator selection bug (elastic#71178)
  [SIEM][Detection Engine] Speeds up value list imports by enabling streaming of files.
  [APM] Update ML job ID in data telemetry tasks (elastic#71044)
  [Resolver] Remove `currentPanelView` selector (elastic#71154)
  add meta.managed to index templates (elastic#71135)
  Clarify trial subscription levels (elastic#70900)
  [Security Solution] fix panel links (elastic#71148)
  skip flaky suite (elastic#69632)
  skip suite failing ES Promotion (elastic#71018)
  [ML] DF Analytics: add results field to wizard and show regression stats (elastic#70893)
  [SIEM] update wordings (elastic#71119)
  [SECURITY SOLUTION] Rename to hosts and administration (elastic#70913)
  [ML] Improvements for urlState hook. (elastic#70576)
  Removing uptime guide (elastic#71124)
  ...
XavierM added a commit that referenced this pull request Jul 9, 2020
* Fix bug when you move columns rule name

* reference.url and event.url will be render as an anchor

* no need to fake index just return null
@cnasikas cnasikas linked an issue Jul 14, 2020 that may be closed by this pull request
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SIEM][Timeline] Reordering of column invalidates data.
5 participants