Use "Apply_filter_trigger" in "explore underlying data" action #71445

Dosant · 2020-07-13T13:57:39Z

Summary

Small clean up made possible by #70602
Refactor "explore underlying data" action to use apply filter directly

I didn't expect it would also enable this feature for maps 😅
see: #71445 (comment)

For now I disabled it to move forward with this small refactoring because of UX considerations with spatial filter.
Created to follow up: #73043

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

Dosant · 2020-07-16T12:10:54Z

Dear @elastic/kibana-gis,

Recently app-arch team introduced explore underlying data action.
It navigates from visualization to Discover app. It navigates to the index pattern of the visualization and carry overs visualization's filters, query and time range.

Before this pr that action was attached to low level "value_click" and "select_range" triggers, but this pr also attaches it to higher level "apply_filter" trigger.

Since maps use "apply_filter" trigger directly, this new action didn't appear for maps before.
But now it does. This is how it looks:

@elastic/kibana-gis, do you think we should leave it enabled for maps? Or should I disable it?

elasticmachine · 2020-07-16T12:12:25Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

nreese · 2020-07-16T15:57:59Z

do you think we should leave it enabled for maps? Or should I disable it?

There are a couple of cases where "explore underlying data" provides an awkward user experience as is.

spatial filters. Users can draw on the map to create spatial filters. In this case, the current UI appears broken because when the user if finished drawing the filter, instead of the filter being created, there is an odd looking pop-up. I think in this case, the action needs to be configured before the filter is created. Maps provides a UI before drawing to allow users to configure the filter. "explore underlying data" needs to be part of this UI and not after filter creation.

"explore underlying data" is not displayed when filtering by a property field, https://www.elastic.co/guide/en/kibana/current/maps-create-filter-from-map.html#maps-phrase-filter.

…igger-underlying-data

Dosant · 2020-07-20T11:47:23Z

Thanks @nreese for checking this out.

I guess we could find a way to disable that for some cases. Do you think it is worth looking into it?
Didn't find this case, for example, is this the same filter that you are referring to?

Maybe you've checked that not inside map embeddable? (this functionality relies on embeddable and index pattern in embeddable output)

nreese · 2020-07-21T13:35:42Z

I guess we could find a way to disable that for some cases. Do you think it is worth looking into it?

For spatial filtering it really makes sense to disable this feature when the filter is added. I think the effort is worth looking into for better usability

streamich

I think for purposes of this PR we should disable this action for Maps, and address it separately. Othwerwise, LGTM, checked on Ubuntu/Chrome.

…igger-underlying-data # Conflicts: # x-pack/plugins/discover_enhanced/public/actions/explore_data/abstract_explore_data_action.ts # x-pack/plugins/discover_enhanced/public/actions/explore_data/explore_data_chart_action.test.ts # x-pack/plugins/discover_enhanced/public/actions/explore_data/explore_data_context_menu_action.test.ts

Dosant · 2020-07-27T07:37:51Z

@elasticmachine merge upstream

Dosant · 2020-07-28T14:04:33Z

@elasticmachine merge upstream

flash1293

Tested in Chrome and Firefox, still works fine for me - filters and ranges get carried over correctly. Not super familiar with the code, but Kibana app changes look sensible to me (I like how we don't need the embeddable service anymore)

Dosant · 2020-07-31T13:54:08Z

@elasticmachine merge upstream

Dosant · 2020-08-01T06:18:56Z

@elasticmachine merge upstream

kibanamachine · 2020-08-01T08:03:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fc433ac

Build metrics

page load bundle size

id	value	diff	baseline
discoverEnhanced	29.4KB	+1.9KB	27.5KB
embeddable	428.7KB	-3.0KB	431.7KB
total	-	-1.2KB	-

History

💚 Build #65800 succeeded 5f76389
💚 Build #64747 succeeded 8521863
💔 Build #64705 failed 22d58b0
💚 Build #64248 succeeded c2ea947
💚 Build #63913 succeeded e0eea6f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ic#71445) * use apply filter trigger for “expore underlying data” * disable for maps for now Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

… (#74045) * use apply filter trigger for “expore underlying data” * disable for maps for now Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (39 commits) [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853) [Canvas] Storybook Redux Addon (elastic#73227) Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445) [maps] convert top nav config to TS (elastic#73851) [maps] fix fit to bounds for ES document layers with joins (elastic#73985) [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309) [CI] In-progress Slack notifications (elastic#74012) [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003) [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989) Tweak injected metadata (elastic#73990) Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999) [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991) [Security Solution] Fix timeline pin event callback (elastic#73981) [Security Solution] Fix unexpected redirect (elastic#73969) [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986) [APM] docs: Update machine learning integration (elastic#73597) [Ingest Manager] Fix limited concurrency helper (elastic#73976) [build/sysv] fix missing env variable rename (elastic#73977) Fix a typo. (elastic#73948) [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940) ...

Dosant requested a review from streamich July 13, 2020 13:57

Dosant mentioned this pull request Jul 13, 2020

[uiActions] Support emitting nested triggers and actions #70602

Merged

2 tasks

use apply filter trigger for “expore underlying data”

313e546

Dosant force-pushed the dev/nested-trigger-underlying-data branch from 76c3867 to 313e546 Compare July 16, 2020 11:31

Dosant added refactoring Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 Feature:UIActions UI actions. These are client side only, not related to the server side actions.. labels Jul 16, 2020

Dosant marked this pull request as ready for review July 16, 2020 12:12

Dosant requested a review from a team July 16, 2020 12:12

Dosant requested a review from a team as a code owner July 16, 2020 12:12

botelastic bot added the Feature:Embedding Embedding content via iFrame label Jul 16, 2020

Dosant requested a review from a team July 16, 2020 12:12

Dosant added 2 commits July 20, 2020 12:37

Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…

7d9c235

…igger-underlying-data

Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…

5683fbf

…igger-underlying-data

better userfacing name for trigger

9505524

Dosant marked this pull request as draft July 21, 2020 14:23

Dosant mentioned this pull request Jul 21, 2020

[discuss][uiActions] How to force specific action execution? #72673

Closed

streamich approved these changes Jul 22, 2020

View reviewed changes

Dosant mentioned this pull request Jul 23, 2020

"Explore_underlying_data" action in Maps #73043

Closed

Dosant added 2 commits July 23, 2020 15:04

fix formatting

f6ee31a

disable for maps for now

965de76

Dosant removed the request for review from a team July 23, 2020 13:16

Dosant marked this pull request as ready for review July 23, 2020 13:17

Dosant requested a review from kertal July 23, 2020 13:17

bad merge fix

e0eea6f

Merge branch 'master' into dev/nested-trigger-underlying-data

c2ea947

elasticmachine and others added 2 commits July 28, 2020 08:04

Merge branch 'master' into dev/nested-trigger-underlying-data

22d58b0

fix bad merge

8521863

Dosant requested review from flash1293 and removed request for kertal July 28, 2020 15:38

flash1293 approved these changes Jul 30, 2020

View reviewed changes

Merge branch 'master' into dev/nested-trigger-underlying-data

5f76389

Merge branch 'master' into dev/nested-trigger-underlying-data

fc433ac

Dosant merged commit 56e51bd into elastic:master Aug 1, 2020

Dosant mentioned this pull request Aug 1, 2020

[7.x] Use "Apply_filter_trigger" in "explore underlying data" action (#71445) #74045

Merged

Dosant mentioned this pull request Aug 4, 2020

Dev/explore underlying data in maps poc #73067

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use "Apply_filter_trigger" in "explore underlying data" action #71445

Use "Apply_filter_trigger" in "explore underlying data" action #71445

Dosant commented Jul 13, 2020 •

edited

Loading

Dosant commented Jul 16, 2020

elasticmachine commented Jul 16, 2020

nreese commented Jul 16, 2020 •

edited

Loading

Dosant commented Jul 20, 2020

nreese commented Jul 21, 2020

streamich left a comment

Dosant commented Jul 27, 2020

Dosant commented Jul 28, 2020

flash1293 left a comment

Dosant commented Jul 31, 2020

Dosant commented Aug 1, 2020

kibanamachine commented Aug 1, 2020

Use "Apply_filter_trigger" in "explore underlying data" action #71445

Use "Apply_filter_trigger" in "explore underlying data" action #71445

Conversation

Dosant commented Jul 13, 2020 • edited Loading

Summary

Checklist

Dosant commented Jul 16, 2020

elasticmachine commented Jul 16, 2020

nreese commented Jul 16, 2020 • edited Loading

Dosant commented Jul 20, 2020

nreese commented Jul 21, 2020

streamich left a comment

Choose a reason for hiding this comment

Dosant commented Jul 27, 2020

Dosant commented Jul 28, 2020

flash1293 left a comment

Choose a reason for hiding this comment

Dosant commented Jul 31, 2020

Dosant commented Aug 1, 2020

kibanamachine commented Aug 1, 2020

💚 Build Succeeded

Build metrics

page load bundle size

History

Dosant commented Jul 13, 2020 •

edited

Loading

nreese commented Jul 16, 2020 •

edited

Loading