[build/sysv] fix missing env variable rename #73977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations (Team:Operations) |
I'm confused by this statement. I'm having this failure on CentOS 7 which has systemd. |
|
@LeeDr are you using the init script? |
|
@LeeDr here are the builds for testing: https://drive.google.com/drive/folders/1e7QNx1zkKL5j-gG3MGzEday8t83I0XsN?usp=sharing |
tylersmalley
approved these changes
Jul 31, 2020
|
Some linux distributions (e.g. fedora) have both but don't have systemd symlinked to 'service' yet. |
LeeDr
approved these changes
Jul 31, 2020
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
jbudz
added a commit
that referenced
this pull request
Jul 31, 2020
jbudz
added a commit
that referenced
this pull request
Jul 31, 2020
|
7.x: c5a5840 |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 2, 2020
* master: (39 commits) [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853) [Canvas] Storybook Redux Addon (elastic#73227) Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445) [maps] convert top nav config to TS (elastic#73851) [maps] fix fit to bounds for ES document layers with joins (elastic#73985) [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309) [CI] In-progress Slack notifications (elastic#74012) [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003) [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989) Tweak injected metadata (elastic#73990) Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999) [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991) [Security Solution] Fix timeline pin event callback (elastic#73981) [Security Solution] Fix unexpected redirect (elastic#73969) [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986) [APM] docs: Update machine learning integration (elastic#73597) [Ingest Manager] Fix limited concurrency helper (elastic#73976) [build/sysv] fix missing env variable rename (elastic#73977) Fix a typo. (elastic#73948) [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940) ...
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously (unreleased/not documented) we had two sets of prefixes for environment variables - KBN and KIBANA. These were refactored to be consistent, and my find and replace missed this one because it matches a (default? or gitignore?) exclusion of /build/ in my text editor.
Testing - this only effects sysv. prior snapshots would fallback to a local config folder and it wouldn't exist. It should start now
Closes #73743