[SECURITY_SOLUTION][ENDPOINT] Handle Host list/details policy links to non-existing policies #73208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
v8.0.0
release_note:skip
|
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
paul-tavares
commented
Jul 24, 2020
| hostResponse.hosts, | ||
| nonExistingPolicies(state) | ||
| ) | ||
| .then((missingPolicies) => { |
There was a problem hiding this comment.
FYI: I don't like that these then().catch() blocks are repeated below. Will look to improve in the future (maybe by passing along the dispatch method to the getNonexistingPoliciesForHostList() as an argument.
|
@elasticmachine merge upstream |
|
Do you plan to backport this change? |
|
@nnamdifrankie yes - tagged 7.9 ++ 7.10 😬 |
|
pulled it down locally, working as expected
|
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
kevinlog
approved these changes
Jul 27, 2020
aisantos
approved these changes
Jul 27, 2020
paul-tavares
deleted the
task/EMT-634-handle-host-links-to-deleted-policy
branch
paul-tavares
added a commit
to paul-tavares/kibana
that referenced
this pull request
Jul 27, 2020
…o non-existing policies (elastic#73208) * Make API call to check policies and save it to store * change policy list and details to not show policy as a link if it does not exist
paul-tavares
added a commit
to paul-tavares/kibana
that referenced
this pull request
Jul 27, 2020
…o non-existing policies (elastic#73208) * Make API call to check policies and save it to store * change policy list and details to not show policy as a link if it does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why:
When the Endpoint Policy is deleted, that action is immediate (Ingest Package Configuration is deleted), however the un-installing of the Endpoint (as a result of this delete action) may take a bit of time, during which it will continue to show up on the Endpoint Hosts list, and thus with invalid URLs to the Policy Details.
Checklist