Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove "Are you sure" from data frame analytics jobs #76214

Merged
merged 4 commits into from
Sep 1, 2020
Merged

[ML] Remove "Are you sure" from data frame analytics jobs #76214

merged 4 commits into from
Sep 1, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 27, 2020 •
edited
Loading

Summary

Per https://elastic.github.io/eui/#/guidelines/writing, we should avoid using "Are you sure" in our UI messages. This PR cleans up some data frame analytic-related occurrences of that text.

Checklist

Delete any items that are not applicable to this PR.

Screenshots (Before)

Delete a data frame analytics job:

image

Start a data frame analytics job:

image

Screenshots (After)

Delete a data frame analytics job:

image

Start a job:

image

@lcawl lcawl marked this pull request as ready for review August 28, 2020 01:03
@lcawl lcawl requested a review from a team as a code owner August 28, 2020 01:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Aug 28, 2020
@lcawl
Copy link
Contributor Author

lcawl commented Aug 31, 2020

@elasticmachine merge upstream

gchaps
gchaps reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if you can shorten the radio buttons and maybe include the word "job" in the title:

Delete job outliers1?

Delete destination index
Delete index pattern

Cancel | Delete

Does the name of an analytics job ever get very long? If so, you might want to use a more generic title like "Delete this analytics job?"

...ta_frame_analytics/pages/analytics_management/components/action_start/start_action_modal.tsx Outdated Show resolved Hide resolved
@lcawl
Copy link
Contributor Author

lcawl commented Sep 1, 2020

Does the name of an analytics job ever get very long? If so, you might want to use a more generic title like "Delete this analytics job?"

I think that even if we remove the job name from the title, we'd want to keep the names for the destination index and index pattern, since I think those might differ from the job name. I used quick default values, so that's why they're the same in this case.

peteharverson
peteharverson approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

I think it's worth keeping the index / index pattern names in the modal to clarify exactly what will be deleted, because as @lcawl commented, they might not have the same name as the job, e.g.

image

@lcawl lcawl removed the v7.11.0 label Sep 1, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.2MB -1.1KB 8.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit ff7e7ef into elastic:master Sep 1, 2020
@lcawl lcawl deleted the dfanalytics-text branch September 1, 2020 17:42
@lcawl lcawl mentioned this pull request Sep 1, 2020
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 1, 2020
@lcawl
[ML] Remove "Are you sure" from data frame analytics jobs (elastic#76214
2bdce95 
)
lcawl added a commit that referenced this pull request Sep 1, 2020
@lcawl
[ML] Remove "Are you sure" from data frame analytics jobs (#76214) (#…
23cc60c 
…76410)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 2, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
c9deb85 
* master: (223 commits)
  skip flaky suite (elastic#75724)
  [Reporting] Add functional test for Reports in non-default spaces (elastic#76053)
  [Enterprise Search] Fix various icons in dark mode (elastic#76430)
  skip flaky suite (elastic#76245)
  Add `auto` interval to histogram AggConfig (elastic#76001)
  [Resolver] generator uses setup_node_env (elastic#76422)
  [Ingest Manager] Support both zip & tar archives from Registry (elastic#76197)
  [Ingest Manager] Improve agent vs kibana version checks (elastic#76238)
  Manually building `KueryNode` for Fleet's routes (elastic#75693)
  remove dupe tinymath section (elastic#76093)
  Create APM issue template (elastic#76362)
  Delete unused file. (elastic#76386)
  [SECURITY_SOLUTION][ENDPOINT] Trusted Apps Create API (elastic#76178)
  [Detections Engine] Add Alert actions to the Timeline (elastic#73228)
  [Dashboard First] Library Notification (elastic#76122)
  [Maps] Add mvt support for ES doc sources  (elastic#75698)
  Add setHeaderActionMenu API to AppMountParameters (elastic#75422)
  [ML] Remove "Are you sure" from data frame analytics jobs (elastic#76214)
  [yarn] remove typings-tester, use @ts-expect-error (elastic#76341)
  [Reporting/CSV] Do not fail the job if scroll ID can not be cleared (elastic#76014)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @elasticmachine @kibanamachine @peteharverson @gchaps