Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove "Are you sure" from data frame analytics jobs #76214

Merged
merged 4 commits into from
Sep 1, 2020
Merged

[ML] Remove "Are you sure" from data frame analytics jobs #76214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3f2c3e
[ML] Remove unnecessary analytics text
lcawl Aug 27, 2020
1a7e466
Removes redundant import
lcawl Aug 27, 2020
df0418e
Merge branch 'master' into dfanalytics-text
elasticmachine Aug 31, 2020
3e13a88
Addresses feedback
lcawl Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions ...ame_analytics/pages/analytics_management/components/action_delete/delete_action_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
EuiFlexItem,
EUI_MODAL_CONFIRM_BUTTON,
} from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';

import { DeleteAction } from './use_delete_action';

Expand All @@ -40,7 +39,7 @@ export const DeleteActionModal: FC<DeleteAction> = ({
<EuiConfirmModal
data-test-subj="mlAnalyticsJobDeleteModal"
title={i18n.translate('xpack.ml.dataframe.analyticsList.deleteModalTitle', {
defaultMessage: 'Delete {analyticsId}',
defaultMessage: 'Delete {analyticsId}?',
values: { analyticsId: item.config.id },
})}
onCancel={closeModal}
Expand All @@ -60,13 +59,6 @@ export const DeleteActionModal: FC<DeleteAction> = ({
defaultFocusedButton={EUI_MODAL_CONFIRM_BUTTON}
buttonColor="danger"
>
<p>
<FormattedMessage
id="xpack.ml.dataframe.analyticsList.deleteModalBody"
defaultMessage="Are you sure you want to delete this analytics job?"
/>
</p>

<EuiFlexGroup direction="column" gutterSize="none">
<EuiFlexItem>
{userCanDeleteIndex && (
Expand Down
4 changes: 2 additions & 2 deletions ...frame_analytics/pages/analytics_management/components/action_start/start_action_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const StartActionModal: FC<StartAction> = ({ closeModal, item, startAndCl
<EuiOverlayMask>
<EuiConfirmModal
title={i18n.translate('xpack.ml.dataframe.analyticsList.startModalTitle', {
defaultMessage: 'Start {analyticsId}',
defaultMessage: 'Start {analyticsId}?',
values: { analyticsId: item.config.id },
})}
onCancel={closeModal}
Expand All @@ -40,7 +40,7 @@ export const StartActionModal: FC<StartAction> = ({ closeModal, item, startAndCl
<p>
{i18n.translate('xpack.ml.dataframe.analyticsList.startModalBody', {
defaultMessage:
'A data frame analytics job will increase search and indexing load in your cluster. Please stop the analytics job if excessive load is experienced. Are you sure you want to start this analytics job?',
'A data frame analytics job increases search and indexing load in your cluster. If excessive load occurs, stop the job.',
})}
</p>
</EuiConfirmModal>
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11139,7 +11139,6 @@
"xpack.ml.dataframe.analyticsList.deleteAnalyticsWithIndexPatternSuccessMessage": "インデックスパターン{destinationIndex}を削除する要求が確認されました。",
"xpack.ml.dataframe.analyticsList.deleteAnalyticsWithIndexSuccessMessage": "ディスティネーションインデックス{destinationIndex}を削除する要求が確認されました。",
"xpack.ml.dataframe.analyticsList.deleteDestinationIndexTitle": "ディスティネーションインデックス{indexName}を削除",
"xpack.ml.dataframe.analyticsList.deleteModalBody": "この分析ジョブを削除してよろしいですか？",
"xpack.ml.dataframe.analyticsList.deleteModalCancelButton": "キャンセル",
"xpack.ml.dataframe.analyticsList.deleteModalDeleteButton": "削除",
"xpack.ml.dataframe.analyticsList.deleteModalTitle": "{analyticsId}の削除",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11142,7 +11142,6 @@
"xpack.ml.dataframe.analyticsList.deleteAnalyticsWithIndexPatternSuccessMessage": "删除索引模式 {destinationIndex} 的请求已确认。",
"xpack.ml.dataframe.analyticsList.deleteAnalyticsWithIndexSuccessMessage": "删除目标索引 {destinationIndex} 的请求已确认。",
"xpack.ml.dataframe.analyticsList.deleteDestinationIndexTitle": "删除目标索引 {indexName}",
"xpack.ml.dataframe.analyticsList.deleteModalBody": "是否确定要删除此分析作业？",
"xpack.ml.dataframe.analyticsList.deleteModalCancelButton": "取消",
"xpack.ml.dataframe.analyticsList.deleteModalDeleteButton": "删除",
"xpack.ml.dataframe.analyticsList.deleteModalTitle": "删除 {analyticsId}",
Expand Down