Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vega related modules #78462

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 24, 2020

This PR contains the following updates:

Package Type Update Change
vega devDependencies minor ^5.13.0 -> ^5.16.1
vega-lite (source) devDependencies minor ^4.13.1 -> ^4.16.7
vega-schema-url-parser devDependencies major ^1.1.0 -> ^2.1.0
vega-tooltip devDependencies minor ^0.12.0 -> ^0.24.2

Release Notes

vega/vega

v5.16.1

Compare Source

Changes from v5.16.0:

monorepo

  • Fix rollup config to use umd rather than iife bundles. (#​2896)

v5.16.0

Compare Source

Notable Changes
  • The new label transform automatically positions labels without overlapping other marks. (Thanks @​chanwutk!)
  • Completes the transition to using vega-datasets 2.0+, including swapping out the Iris dataset for a more adorable Penguins dataset. 🐧
  • Major update of build system to use a centralized rollup configuration. (Thanks @​domoritz!)
Changelog

Changes from v5.15.0:

docs

monorepo

  • Complete transition to vega-datasets 2.0.
  • Use centralized rollup config. (thanks @​domoritz!)

vega

  • Use centralized rollup config. (thanks @​domoritz!)
  • Update and extend test specifications.

vega-canvas

vega-crossfilter

vega-dataflow

vega-encode

vega-event-selector

vega-expression

  • Use forbidden / allowed, remove blacklist / whitelist (Breaking change)
  • Fix use of var, prefer const and let. (thanks @​lgrammel!)
  • Use centralized rollup config. (thanks @​domoritz!)

vega-functions

vega-force

vega-format

vega-geo

vega-hierarchy

vega-interpreter

vega-label

  • 1.0.0 release, now integrated into Vega! (thanks @​chanwutk!)
  • Fix use of var, prefer const and let. (thanks @​lgrammel!)
  • Use centralized rollup config. (thanks @​domoritz!)

vega-loader

vega-parser

vega-projection

vega-projection-extended

vega-regression

vega-runtime

vega-scale

vega-scenegraph

vega-schema

vega-selections

vega-statistics

vega-time

vega-transforms

vega-typings

vega-util

vega-view-transforms

vega-view

vega-voronoi

vega-wordcloud

v5.15.0

Compare Source

Changes from v5.14.0:

monorepo

  • Update dependencies, including use of D3 v6 packages.
  • Refactor all packages for JavaScript modernization. (thanks @​domoritz & @​lgrammel!)

vega

  • Update vega-core build to use D3 v6.

vega-scale

v5.14.0

Compare Source

Notable Changes
  • Update SVG rendering to produce fully compliant XML. (#​2672)
  • Major refactoring of the Vega code to be more lean and modern. The main changes are:
    • Use shorthand property method syntax (e.g., rather than assignment to prototype objects).
    • Use arrow functions rather than function declarations where appropriate.
    • Prefer use of let and const to var.
  • Upgrade the documentation examples to use vega-datasets 2.0+, including swapping out the Iris dataset for a more adorable Penguins dataset. 🐧
  • Various bug fixes, documented below.
Changelog

Changes from v5.13.0:

vega-cli

  • Update SVG test output.

vega-canvas

  • Update to use leaner syntax.

vega-crossfilter

  • Update to use leaner syntax.

vega-dataflow

  • Fix EventStream to support detach method. (#​2753)
  • Fix Pulse addAll to clear rem set when applicable. This prevents tuple removal from being invoked on newly instantiated operators that never observed those tuples in the first place. (#​2605)
  • Update to use leaner syntax.

vega-encode

  • Update to use leaner syntax.

vega-event-selector

  • Update to use leaner syntax.

vega-expression

  • Update to use leaner syntax.

vega-force

  • Update to use leaner syntax.

vega-format

  • Update to use leaner syntax.

vega-functions

  • Update to use leaner syntax.

vega-geo

  • Update to use leaner syntax.

vega-hierarchy

  • Update to use leaner syntax.

vega-label

  • Update to use leaner syntax.

vega-loader

  • Update to use leaner syntax.

vega-parser

  • Fix production rule support for guides. (#​2754)
  • Update to use leaner syntax.

vega-projection

  • Update to use leaner syntax.

vega-regression

  • Update to use leaner syntax.

vega-scale

  • Update to use leaner syntax.

vega-scenegraph

  • Add markup and serializeXML utilities for SVG string output. Ensure proper XML output. (#​2672)
  • Fix leaky SVG scaleX/Y transforms on non-path marks. (#​2738)
  • Fix bounds calculation for rotated paths. (#​2780)
  • Fix canvas picking for clipped groups with corner radius and no fill. (#​2797)
  • Fix SVG path parsing: support concatenated decimals and implicit lineTo commands. (#​2803)
  • Update tests, add xmllint checks to test conformance of SVG output.
  • Update to use leaner syntax.
  • Internal Breaking Change: Update SVGStringRenderer class methods to use markup utility.
  • Internal Breaking Change: Drop openTag, closeTag utilities.

vega-statistics

  • Update to use leaner syntax.

vega-time

  • Update to use leaner syntax.

vega-transforms

  • Update to use leaner syntax.

vega-view-transforms

  • Update to use leaner syntax.

vega-view

  • Update to use leaner syntax.

vega-util

  • Add members argument to inherits utility.
  • Add ascending comparator utility.
  • Update to use leaner syntax.

vega-voronoi

  • Update to use leaner syntax.

vega-wordcloud

  • Update to use leaner syntax.
vega/vega-lite

v4.16.7

Compare Source

Bug Fixes

v4.16.6

Compare Source

v4.16.5

Compare Source

v4.16.4

Compare Source

A patch release to fix the automatic release process.

v4.16.2

Compare Source

Bug Fixes

v4.16.1

Compare Source

A patch release to fix the automatic release process.

v4.15.0

Compare Source

Bug Fixes
  • add color encoding to boxplot outliers (#​6820) (80598e6)
  • add missing type inference logic for LT/LTE/GT/GTE predicates (#​6807) (5789290)
  • mark units w/o selections as interactive if they have a tooltip (#​6839) (31a65c0)
Features
Other
  • update dependencies

v4.14.1

Compare Source

Bug Fixes

v4.14.0

Compare Source

Features
Bug Fixes
  • apply labelOverlap to ordinal time unit without custom sort, not any ordinal (#​6648) (0b119ca)
  • boxplot should include description on the box layer, not mid tick (a96db36)
  • change bump script to support non-master release (f350441)
  • correctly apply conditional dash offsets (#​6599) (7a973bf), closes #​6591
  • do not apply axis/legend title to tooltip title (#​6689) (1c380be)
  • don't add guide properties to tooltips, use encoding titles for boxplot titles (#​6674) (1a03102)
  • don't rotate labels for ordinal timeUnit (#​6649) (5e23aed)
  • fix axis translate signal for binned bar marks (#​6754) (fd1de4f)
  • make datum.label in labelExpr work with custom formatter (44faaf3), closes #​6581
  • make tooltip support signal (#​6692) (8707c7a), closes #​6490
  • only run simple optimizations before facet nodes are moved (#​6453) (5c1941b)
  • prefer the axis with temporal type to be the non-aggregated axis in composite marks (#​6501) (2cf98a6)
  • remove transformextract test (8234b03), closes #​4419
  • respect symbolOpacity, gradientOpacity, symbolFillColor, and symbolStrokeColor (#​6724) (59c93a3)
  • revert "docs: use penguins data for boxplots" (#​6662) (3cf0eeb)
  • revert to object for inlineDataset element (#​6588) (ce4c51f)
  • tell npx where to find vega scripts (#​6608) (5ec337d)
vega/schema

v2.1.0

Compare Source

v2.0.0

Compare Source

vega/vega-tooltip

v0.24.2

Compare Source

v0.24.1

Compare Source

v0.24.0

Compare Source

v0.23.2

Compare Source

v0.23.1

Compare Source

v0.23.0

Compare Source

v0.22.1

Compare Source

v0.22.0

Compare Source

v0.21.0

Compare Source

v0.20.1

Compare Source

v0.20.0

Compare Source

v0.19.1

Compare Source

v0.19.0

Compare Source

v0.18.1

Compare Source

v0.18.0

Compare Source

v0.17.2

Compare Source

v0.17.1

Compare Source

v0.17.0

Compare Source

v0.16.0

Compare Source

v0.15.0

Compare Source

v0.14.0

Compare Source

v0.13.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 24, 2020
@renovate renovate bot requested a review from a team September 24, 2020 17:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@renovate renovate bot force-pushed the renovate/vega-related-modules branch 2 times, most recently from 5a35f63 to 2110777 Compare September 26, 2020 20:37
@renovate renovate bot force-pushed the renovate/vega-related-modules branch from 2110777 to c3a06a8 Compare September 26, 2020 20:53
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 26, 2020

💔 Build Failed

Failed CI Steps


Test Failures

Jest Tests.src/plugins/vis_type_vega/public.VegaVisualizations VegaVisualization - basics should show vegalite graph and update on resize (may fail in dev env)

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `VegaVisualizations VegaVisualization - basics should show vegalite graph and update on resize (may fail in dev env) 1`

Snapshot: "<div class=\"vgaVis__view\" style=\"height: 100%; cursor: default;\" role=\"graphics-document\" aria-roledescription=\"visualization\" aria-label=\"Vega visualization\"><svg class=\"marks\" width=\"512\" height=\"506\" viewBox=\"0 0 512 506\" style=\"background-color: transparent;\"><g fill=\"none\" stroke-miterlimit=\"10\" transform=\"translate(7,5)\"><g class=\"mark-group role-frame root\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0.5,0.5h498v494h-498Z\" fill=\"transparent\" stroke=\"#ddd\"></path><g><g class=\"mark-line role-mark marks\" role=\"graphics-object\" aria-roledescription=\"line mark container\"><path aria-label=\"key: Dec 11, 2017; doc_count: 0\" role=\"graphics-symbol\" aria-roledescription=\"line mark\" d=\"M0,494L55.33333333333333,494L110.66666666666666,494L166,44.953999999999986L221.33333333333331,32.9004L276.6666666666667,33.59199999999998L332,480.8596L387.3333333333333,494L442.66666666666663,494L498,494\" stroke=\"#54B399\" stroke-width=\"2\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g></svg></div><div class=\"vgaVis__controls vgaVis__controls--column\"></div>"
Received: "<div class=\"vgaVis__view\" style=\"height: 100%; cursor: default;\" role=\"graphics-document\" aria-roledescription=\"visualization\" aria-label=\"Vega visualization\"><svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\" class=\"marks\" width=\"512\" height=\"506\" viewBox=\"0 0 512 506\" style=\"background-color: transparent;\"><g fill=\"none\" stroke-miterlimit=\"10\" transform=\"translate(7,5)\"><g class=\"mark-group role-frame root\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0.5,0.5h498v494h-498Z\" fill=\"transparent\" stroke=\"#ddd\"></path><g><g class=\"mark-line role-mark marks\" role=\"graphics-object\" aria-roledescription=\"line mark container\"><path aria-label=\"key: Dec 11, 2017; doc_count: 0\" role=\"graphics-symbol\" aria-roledescription=\"line mark\" d=\"M0,494L55.33333333333333,494L110.66666666666666,494L166,44.953999999999986L221.33333333333331,32.9004L276.6666666666667,33.59199999999998L332,480.8596L387.3333333333333,494L442.66666666666663,494L498,494\" stroke=\"#54B399\" stroke-width=\"2\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g></svg></div><div class=\"vgaVis__controls vgaVis__controls--column\"></div>"
    at Object.test (/dev/shm/workspace/parallel/5/kibana/src/plugins/vis_type_vega/public/vega_visualization.test.js:135:35)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Jest Tests.src/plugins/vis_type_vega/public.VegaVisualizations VegaVisualization - basics should show vega graph (may fail in dev env)

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `VegaVisualizations VegaVisualization - basics should show vega graph (may fail in dev env) 1`

Snapshot: "<div class=\"vgaVis__view\" style=\"height: 100%; cursor: default;\" role=\"graphics-document\" aria-roledescription=\"visualization\" aria-label=\"Vega visualization\"><svg class=\"marks\" width=\"512\" height=\"512\" viewBox=\"0 0 512 512\" style=\"background-color: transparent;\"><g fill=\"none\" stroke-miterlimit=\"10\" transform=\"translate(0,0)\"><g class=\"mark-group role-frame root\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0,0h512v512h-512Z\"></path><g><g class=\"mark-group role-scope\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0,0h0v0h0Z\"></path><g><g class=\"mark-area role-mark\" role=\"graphics-symbol\" aria-roledescription=\"area mark container\"><path d=\"M0,512C18.962962962962962,512,37.925925925925924,512,56.888888888888886,512C75.85185185185185,512,94.81481481481481,512,113.77777777777777,512C132.74074074074073,512,151.7037037037037,512,170.66666666666666,512C189.62962962962962,512,208.59259259259258,512,227.55555555555554,512C246.5185185185185,512,265.48148148148147,512,284.44444444444446,512C303.4074074074074,512,322.3703703703704,512,341.3333333333333,512C360.29629629629625,512,379.25925925925924,512,398.2222222222222,512C417.18518518518516,512,436.1481481481481,512,455.1111111111111,512C474.0740740740741,512,493.037037037037,512,512,512L512,355.2C493.037037037037,324.79999999999995,474.0740740740741,294.4,455.1111111111111,294.4C436.1481481481481,294.4,417.18518518518516,457.6,398.2222222222222,457.6C379.25925925925924,457.6,360.29629629629625,233.60000000000002,341.3333333333333,233.60000000000002C322.3703703703704,233.60000000000002,303.4074074074074,435.2,284.44444444444446,435.2C265.48148148148147,435.2,246.5185185185185,345.6,227.55555555555554,345.6C208.59259259259258,345.6,189.62962962962962,451.2,170.66666666666666,451.2C151.7037037037037,451.2,132.74074074074073,252.8,113.77777777777777,252.8C94.81481481481481,252.8,75.85185185185185,346.1333333333333,56.888888888888886,374.4C37.925925925925924,402.66666666666663,18.962962962962962,412.5333333333333,0,422.4Z\" fill=\"#54B399\" fill-opacity=\"1\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0,0h0v0h0Z\"></path><g><g class=\"mark-area role-mark\" role=\"graphics-symbol\" aria-roledescription=\"area mark container\"><path d=\"M0,422.4C18.962962962962962,412.5333333333333,37.925925925925924,402.66666666666663,56.888888888888886,374.4C75.85185185185185,346.1333333333333,94.81481481481481,252.8,113.77777777777777,252.8C132.74074074074073,252.8,151.7037037037037,451.2,170.66666666666666,451.2C189.62962962962962,451.2,208.59259259259258,345.6,227.55555555555554,345.6C246.5185185185185,345.6,265.48148148148147,435.2,284.44444444444446,435.2C303.4074074074074,435.2,322.3703703703704,233.60000000000002,341.3333333333333,233.60000000000002C360.29629629629625,233.60000000000002,379.25925925925924,457.6,398.2222222222222,457.6C417.18518518518516,457.6,436.1481481481481,294.4,455.1111111111111,294.4C474.0740740740741,294.4,493.037037037037,324.79999999999995,512,355.2L512,307.2C493.037037037037,275.2,474.0740740740741,243.2,455.1111111111111,243.2C436.1481481481481,243.2,417.18518518518516,371.2,398.2222222222222,371.2C379.25925925925924,371.2,360.29629629629625,22.399999999999977,341.3333333333333,22.399999999999977C322.3703703703704,22.399999999999977,303.4074074074074,278.4,284.44444444444446,278.4C265.48148148148147,278.4,246.5185185185185,204.8,227.55555555555554,192C208.59259259259258,179.20000000000002,189.62962962962962,185.6,170.66666666666666,172.8C151.7037037037037,160.00000000000003,132.74074074074073,83.19999999999999,113.77777777777777,83.19999999999999C94.81481481481481,83.19999999999999,75.85185185185185,83.19999999999999,56.888888888888886,83.19999999999999C37.925925925925924,83.19999999999999,18.962962962962962,164.79999999999998,0,246.39999999999998Z\" fill=\"#6092C0\" fill-opacity=\"1\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g></svg></div><div class=\"vgaVis__controls vgaVis__controls--column\"></div>"
Received: "<div class=\"vgaVis__view\" style=\"height: 100%; cursor: default;\" role=\"graphics-document\" aria-roledescription=\"visualization\" aria-label=\"Vega visualization\"><svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\" class=\"marks\" width=\"512\" height=\"512\" viewBox=\"0 0 512 512\" style=\"background-color: transparent;\"><g fill=\"none\" stroke-miterlimit=\"10\" transform=\"translate(0,0)\"><g class=\"mark-group role-frame root\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0,0h512v512h-512Z\"></path><g><g class=\"mark-group role-scope\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0,0h0v0h0Z\"></path><g><g class=\"mark-area role-mark\" role=\"graphics-symbol\" aria-roledescription=\"area mark container\"><path d=\"M0,512C18.962962962962962,512,37.925925925925924,512,56.888888888888886,512C75.85185185185185,512,94.81481481481481,512,113.77777777777777,512C132.74074074074073,512,151.7037037037037,512,170.66666666666666,512C189.62962962962962,512,208.59259259259258,512,227.55555555555554,512C246.5185185185185,512,265.48148148148147,512,284.44444444444446,512C303.4074074074074,512,322.3703703703704,512,341.3333333333333,512C360.29629629629625,512,379.25925925925924,512,398.2222222222222,512C417.18518518518516,512,436.1481481481481,512,455.1111111111111,512C474.0740740740741,512,493.037037037037,512,512,512L512,355.2C493.037037037037,324.79999999999995,474.0740740740741,294.4,455.1111111111111,294.4C436.1481481481481,294.4,417.18518518518516,457.6,398.2222222222222,457.6C379.25925925925924,457.6,360.29629629629625,233.60000000000002,341.3333333333333,233.60000000000002C322.3703703703704,233.60000000000002,303.4074074074074,435.2,284.44444444444446,435.2C265.48148148148147,435.2,246.5185185185185,345.6,227.55555555555554,345.6C208.59259259259258,345.6,189.62962962962962,451.2,170.66666666666666,451.2C151.7037037037037,451.2,132.74074074074073,252.8,113.77777777777777,252.8C94.81481481481481,252.8,75.85185185185185,346.1333333333333,56.888888888888886,374.4C37.925925925925924,402.66666666666663,18.962962962962962,412.5333333333333,0,422.4Z\" fill=\"#54B399\" fill-opacity=\"1\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0,0h0v0h0Z\"></path><g><g class=\"mark-area role-mark\" role=\"graphics-symbol\" aria-roledescription=\"area mark container\"><path d=\"M0,422.4C18.962962962962962,412.5333333333333,37.925925925925924,402.66666666666663,56.888888888888886,374.4C75.85185185185185,346.1333333333333,94.81481481481481,252.8,113.77777777777777,252.8C132.74074074074073,252.8,151.7037037037037,451.2,170.66666666666666,451.2C189.62962962962962,451.2,208.59259259259258,345.6,227.55555555555554,345.6C246.5185185185185,345.6,265.48148148148147,435.2,284.44444444444446,435.2C303.4074074074074,435.2,322.3703703703704,233.60000000000002,341.3333333333333,233.60000000000002C360.29629629629625,233.60000000000002,379.25925925925924,457.6,398.2222222222222,457.6C417.18518518518516,457.6,436.1481481481481,294.4,455.1111111111111,294.4C474.0740740740741,294.4,493.037037037037,324.79999999999995,512,355.2L512,307.2C493.037037037037,275.2,474.0740740740741,243.2,455.1111111111111,243.2C436.1481481481481,243.2,417.18518518518516,371.2,398.2222222222222,371.2C379.25925925925924,371.2,360.29629629629625,22.399999999999977,341.3333333333333,22.399999999999977C322.3703703703704,22.399999999999977,303.4074074074074,278.4,284.44444444444446,278.4C265.48148148148147,278.4,246.5185185185185,204.8,227.55555555555554,192C208.59259259259258,179.20000000000002,189.62962962962962,185.6,170.66666666666666,172.8C151.7037037037037,160.00000000000003,132.74074074074073,83.19999999999999,113.77777777777777,83.19999999999999C94.81481481481481,83.19999999999999,75.85185185185185,83.19999999999999,56.888888888888886,83.19999999999999C37.925925925925924,83.19999999999999,18.962962962962962,164.79999999999998,0,246.39999999999998Z\" fill=\"#6092C0\" fill-opacity=\"1\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g></svg></div><div class=\"vgaVis__controls vgaVis__controls--column\"></div>"
    at Object.test (/dev/shm/workspace/parallel/5/kibana/src/plugins/vis_type_vega/public/vega_visualization.test.js:166:35)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Jest Tests.src/plugins/vis_type_vega/public.VegaVisualizations VegaVisualization - basics should show vega blank rectangle on top of a map (vegamap)

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `VegaVisualizations VegaVisualization - basics should show vega blank rectangle on top of a map (vegamap) 1`

Snapshot: "<div class=\"vgaVis__view leaflet-container leaflet-grab leaflet-touch-drag\" style=\"height: 100%; position: relative;\" tabindex=\"0\"><div class=\"leaflet-pane leaflet-map-pane\" style=\"left: 0px; top: 0px;\"><div class=\"leaflet-pane leaflet-tile-pane\"></div><div class=\"leaflet-pane leaflet-shadow-pane\"></div><div class=\"leaflet-pane leaflet-overlay-pane\"><div class=\"leaflet-vega-container\" role=\"graphics-document\" aria-roledescription=\"visualization\" aria-label=\"Vega visualization\" style=\"left: 0px; top: 0px; cursor: default;\"><svg class=\"marks\" width=\"0\" height=\"0\" viewBox=\"0 0 0 0\" style=\"background-color: transparent;\"><g fill=\"none\" stroke-miterlimit=\"10\" transform=\"translate(0,0)\"><g class=\"mark-group role-frame root\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0,0h0v0h0Z\"></path><g><g class=\"mark-rect role-mark\" role=\"graphics-symbol\" aria-roledescription=\"rect mark container\"><path d=\"M0,0h0v0h0Z\" fill=\"#0f0\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g></svg></div></div><div class=\"leaflet-pane leaflet-marker-pane\"></div><div class=\"leaflet-pane leaflet-tooltip-pane\"></div><div class=\"leaflet-pane leaflet-popup-pane\"></div></div><div class=\"leaflet-control-container\"><div class=\"leaflet-top leaflet-left\"><div class=\"leaflet-control-zoom leaflet-bar leaflet-control\"><a class=\"leaflet-control-zoom-in\" href=\"#\" title=\"Zoom in\" role=\"button\" aria-label=\"Zoom in\">+</a><a class=\"leaflet-control-zoom-out\" href=\"#\" title=\"Zoom out\" role=\"button\" aria-label=\"Zoom out\">−</a></div></div><div class=\"leaflet-top leaflet-right\"></div><div class=\"leaflet-bottom leaflet-left\"></div><div class=\"leaflet-bottom leaflet-right\"><div class=\"leaflet-control-attribution leaflet-control\"></div></div></div></div><div class=\"vgaVis__controls vgaVis__controls--column\"></div>"
Received: "<div class=\"vgaVis__view leaflet-container leaflet-grab leaflet-touch-drag\" style=\"height: 100%; position: relative;\" tabindex=\"0\"><div class=\"leaflet-pane leaflet-map-pane\" style=\"left: 0px; top: 0px;\"><div class=\"leaflet-pane leaflet-tile-pane\"></div><div class=\"leaflet-pane leaflet-shadow-pane\"></div><div class=\"leaflet-pane leaflet-overlay-pane\"><div class=\"leaflet-vega-container\" role=\"graphics-document\" aria-roledescription=\"visualization\" aria-label=\"Vega visualization\" style=\"left: 0px; top: 0px; cursor: default;\"><svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\" class=\"marks\" width=\"0\" height=\"0\" viewBox=\"0 0 0 0\" style=\"background-color: transparent;\"><g fill=\"none\" stroke-miterlimit=\"10\" transform=\"translate(0,0)\"><g class=\"mark-group role-frame root\" role=\"graphics-object\" aria-roledescription=\"group mark container\"><g transform=\"translate(0,0)\"><path class=\"background\" aria-hidden=\"true\" d=\"M0,0h0v0h0Z\"></path><g><g class=\"mark-rect role-mark\" role=\"graphics-symbol\" aria-roledescription=\"rect mark container\"><path d=\"M0,0h0v0h0Z\" fill=\"#0f0\"></path></g></g><path class=\"foreground\" aria-hidden=\"true\" d=\"\" display=\"none\"></path></g></g></g></svg></div></div><div class=\"leaflet-pane leaflet-marker-pane\"></div><div class=\"leaflet-pane leaflet-tooltip-pane\"></div><div class=\"leaflet-pane leaflet-popup-pane\"></div></div><div class=\"leaflet-control-container\"><div class=\"leaflet-top leaflet-left\"><div class=\"leaflet-control-zoom leaflet-bar leaflet-control\"><a class=\"leaflet-control-zoom-in\" href=\"#\" title=\"Zoom in\" role=\"button\" aria-label=\"Zoom in\">+</a><a class=\"leaflet-control-zoom-out\" href=\"#\" title=\"Zoom out\" role=\"button\" aria-label=\"Zoom out\">−</a></div></div><div class=\"leaflet-top leaflet-right\"></div><div class=\"leaflet-bottom leaflet-left\"></div><div class=\"leaflet-bottom leaflet-right\"><div class=\"leaflet-control-attribution leaflet-control\"></div></div></div></div><div class=\"vgaVis__controls vgaVis__controls--column\"></div>"
    at Object.test (/dev/shm/workspace/parallel/5/kibana/src/plugins/vis_type_vega/public/vega_visualization.test.js:193:35)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon
Copy link
Contributor

Looks like this is failing for only one reasons, which is that SVG output was changed in Vega 5.14, so we need to update the snapshots vega/vega#2672

SVG output isn't used in Kibana except for the tests, so this is not really going to affect users.

@wylieconlon
Copy link
Contributor

Closing because it needs test updates

@wylieconlon wylieconlon deleted the renovate/vega-related-modules branch September 28, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants