Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vega] Upgrade vega dependencies #78669

Closed
wants to merge 2 commits into from

Conversation

wylieconlon
Copy link
Contributor

The automatic upgrade was not going through because of changes in snapshots.

Replaces #78462

Checklist

@wylieconlon wylieconlon added Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 28, 2020
@wylieconlon wylieconlon requested review from alexwizp and a team September 28, 2020 19:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
apm 1256 -1 1257
visTypeVega 79 +1 78
total -0

async chunks size

id value diff baseline
apm 4.1MB -8.8KB 4.1MB
visTypeVega 1.4MB +49.0KB 1.4MB
total +40.2KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula
Copy link
Contributor

Thank you @wylieconlon for this. I can see that we have two open PRs for upgrading vega #78390. I suggest to keep the PR of @alexwizp but also upgrade to it the tooltip and url-parser.

@alexwizp
Copy link
Contributor

@wylieconlon agree with @stratoula we also want to remove imports from vega/es5

@wylieconlon
Copy link
Contributor Author

Closing in favor of #78390

@wylieconlon wylieconlon deleted the vega/upgrade-7.10 branch September 29, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants