Improve invalid field error message at search.aggs.param_types.field #78587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
changed the title
kertal
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
reviewed
Sep 28, 2020
| @@ -92,7 +92,7 @@ export class FieldParamType extends BaseParamType { | |||
| defaultMessage: | |||
| 'Saved {fieldParameter} parameter is now invalid. Please select a new field.', | |||
| values: { | |||
| fieldParameter: '"field"', | |||
| fieldParameter: `"${fieldName}"`, | |||
There was a problem hiding this comment.
Since this is targeting a minor, not a patch, we can create new translations. My preference would be a message like Saved field "order_date" is invalid for use with the "terms" aggregation. Please select a new field.
There was a problem hiding this comment.
@wylieconlon done. much better this way 👍
|
@kertal I don't think you pushed the latest code? |
|
@wylieconlon thx, yes, just a screenshot isn't sufficient 😄 , pushed it now |
wylieconlon
reviewed
Sep 29, 2020
wylieconlon
approved these changes
Sep 29, 2020
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
streamich
approved these changes
Sep 30, 2020
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Sep 30, 2020
kertal
added a commit
that referenced
this pull request
Sep 30, 2020
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
Sep 30, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 30, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917) [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593) Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535) update vega version (elastic#78390) Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617) [ILM] Data tier notices should reflect tier preferences (elastic#78398) [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757) Improve invalid field error message at search.aggs.param_types.field (elastic#78587) Remove isDeprecated flag on visType (elastic#78820) Remove unused elasticsearch.preserverHost setting (elastic#78608) Fix condition and adjust tests (elastic#78898) [UX] Add percentile selector (elastic#78562) [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423) expression service docs (elastic#78774) [Functional] Wait for the page to load and then click the new vis button (elastic#78725) [TSVB] No data in visualizations with annotations (elastic#78794) [kbn/ui-shared-deps] track asset sizes (elastic#78718) delete target before building (elastic#78665) Move indexPattern.popularizeField into discover (elastic#77668) [Security Solution][Resolver]Add backdrop to pills (elastic#78625) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve error message at
search.aggs.param_types.field, it was hard coded to"field", now it's displaying thefieldNamethat caused the error.Before:
After:
Note that these messages currently pop up at several test failures:
#39842
#78373