Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve invalid field error message at search.aggs.param_types.field #78587

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Improve invalid field error message at search.aggs.param_types.field #78587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e86bfe
Improve error message
kertal Sep 28, 2020
d6914dc
Remove debug code
kertal Sep 28, 2020
3e8212b
Improve error message
kertal Sep 29, 2020
a542b97
Fix i18n
kertal Sep 29, 2020
d82c35e
use aggConfig.type.title
kertal Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/plugins/data/common/search/aggs/param_types/field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,10 @@ export class FieldParamType extends BaseParamType {
'data.search.aggs.paramTypes.field.invalidSavedFieldParameterErrorMessage',
{
defaultMessage:
'Saved {fieldParameter} parameter is now invalid. Please select a new field.',
'Saved field "{fieldParameter}" is invalid for use with the "{aggType}" aggregation. Please select a new field.',
values: {
fieldParameter: '"field"',
fieldParameter: fieldName,
aggType: aggConfig?.type?.title,
},
}
)
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,7 +1200,6 @@
"data.search.aggs.metrics.uniqueCountTitle": "ユニークカウント",
"data.search.aggs.otherBucket.labelForMissingValuesLabel": "欠測値のラベル",
"data.search.aggs.otherBucket.labelForOtherBucketLabel": "他のバケットのラベル",
"data.search.aggs.paramTypes.field.invalidSavedFieldParameterErrorMessage": "保存した {fieldParameter} パラメーターが無効になりました。新しいフィールドを選択してください。",
"data.search.aggs.paramTypes.field.requiredFieldParameterErrorMessage": "{fieldParameter} は必須パラメーターです",
"data.search.aggs.percentageOfLabel": "{label} の割合",
"data.search.aggs.string.customLabel": "カスタムラベル",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,6 @@
"data.search.aggs.metrics.uniqueCountTitle": "唯一计数",
"data.search.aggs.otherBucket.labelForMissingValuesLabel": "缺失值的标签",
"data.search.aggs.otherBucket.labelForOtherBucketLabel": "其他存储桶的标签",
"data.search.aggs.paramTypes.field.invalidSavedFieldParameterErrorMessage": "保存的 {fieldParameter} 参数现在无效。请选择新字段。",
"data.search.aggs.paramTypes.field.requiredFieldParameterErrorMessage": "{fieldParameter} 是必需字段",
"data.search.aggs.percentageOfLabel": "{label} 的百分比",
"data.search.aggs.string.customLabel": "定制标签",
Expand Down