[kbn/std] add observable helpers to aid with rxjs 7 upgrade #79752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
mshustov
reviewed
Oct 8, 2020
rudolf
reviewed
Oct 8, 2020
rudolf
approved these changes
Oct 8, 2020
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 9, 2020
…79752) Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 9, 2020
…79752) Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Oct 9, 2020
spalger
added a commit
that referenced
this pull request
Oct 9, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 12, 2020
* master: (23 commits) Table visualization renderer (elastic#79455) Migrate Jest JUnit reporter to TS (elastic#79919) store sorted bundleRefExportIds (elastic#80011) update chromedriver dependency to 86.0.0 (elastic#79972) [Security Solution][Case] Fix bug when changing connectors (elastic#80002) [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752) [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038) [Logs UI] Sync logs timerange with wider Kibana (elastic#79444) [DOCS] Adds quick start (elastic#78822) [Ingest Manager]Fix ingest manager UI renaming (elastic#80036) [Monitoring] Fixed internal monitoring check (elastic#79241) [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871) Update development documentation about REST API best practices (elastic#80009) [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190) [CI] Move kibana build dir outside of repo for functional tests (elastic#80018) [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013) [Enterprise Search] Added a Credentials page to App Search (elastic#79749) [DOCS] Canvas refresh for 7.10 (elastic#80017) [TSVB] Add ignore global filters to series options (elastic#79337) Remove this check (elastic#79202) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #79751
Implements 5 observables helpers in
@kbn/std:firstValueFrom(x$: Observable<T>): Promise<T>: equivalent ofx$.pipe(first()).toPromise(), resolves with the first value, unsubscribes after the first notification, rejects ifo$completes without any notifications.lastValueFrom(x$: Observable<T>): Promise<T>: equivalent ofx$.pipe(last()).toPromise(), resolves after the observable completes with the last notification value, rejects ifo$completes without any notifications.In addition to adding these helpers I've consumed them from the
@kbn/optimizer, but as part of working towards #79751 I plan on submitting PRs to different parts of the code base implementing these helpers to remove all of ourtoPromise()usage before we upgrade to RxJS v7.