[kbn/std] update rxjs helpers to use simple operators #80416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
release_note:skip
|
Pinging @elastic/kibana-platform (Team:Platform) |
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
To update your PR or re-run it, just comment with: |
mshustov
approved these changes
Oct 14, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 14, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 14, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Oct 14, 2020
spalger
added a commit
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #79752 I copied the
firstValueFrom()andlastValueFrom()helpers from RxJS v7.beta-7, but there was a bug in those helpers ReactiveX/rxjs#5811, which is now fixed. The fix usesSafeSubscriberin a way that's not supported in RxJS 6, so I've updated the helpers to just use thefirst()andlast()operators to match the behavior of the expectedv7.beta-8release.