Upgrade to hapi version 18 #80468
Merged
Upgrade to hapi version 18 #80468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2020
watson
added
release_note:skip
watson
force-pushed
the
bump-hapi2
branch
6 times, most recently
from
9eb832b
to
39ee6dd
Compare
watson
force-pushed
the
bump-hapi2
branch
4 times, most recently
from
c71308d
to
13edca3
Compare
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
mikecote
approved these changes
Oct 29, 2020
shahzad31
approved these changes
Oct 30, 2020
weltenwort
approved these changes
Oct 30, 2020
rudolf
reviewed
Oct 30, 2020
chrisronline
approved these changes
Oct 30, 2020
crob611
approved these changes
Oct 30, 2020
Good idea. I'll make sure to do that once this is merged |
jgowdyelastic
approved these changes
Oct 30, 2020
jportner
approved these changes
Oct 30, 2020
mshustov
approved these changes
Nov 1, 2020
| @@ -77,6 +77,10 @@ | |||
| "url": "https://github.com/elastic/kibana.git" | |||
| }, | |||
| "resolutions": { | |||
| "**/@hapi/iron": "^5.1.4", | |||
There was a problem hiding this comment.
Why do we need to enforce this resolution? Are there any versions conflicting with each other?
There was a problem hiding this comment.
Some of the hapi modules depend on @hapi/iron version *, which currently resolves to 6.0.0, which isn't compatible with Node.js 10. So to ensure it works with our version of Node.js, I had to force this resolution.
There was a problem hiding this comment.
does it mean we can remove this after #61587 ?
There was a problem hiding this comment.
Yes I would think so - unless there's some other incompatibility that I don't know of. If nothing else, we should be able to remove it once we upgrade to hapi v20, which can be done after the upgrade to Node.js 12.
flash1293
approved these changes
Nov 2, 2020
💚 Build SucceededMetrics [docs]async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
Bamieh
approved these changes
Nov 2, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 2, 2020
…e-details-overlay * 'master' of github.com:elastic/kibana: (72 commits) [CCR] Update README.md on how to start 2 clusters for testing (elastic#81487) [APM] Scale transaction rate correctly (elastic#82155) Upgrade to hapi version 18 (elastic#80468) [Uptime] Remove custom handling of license enabling (elastic#82019) [Telemetry] Remove `from` and `to` timestamps from usage stats APIs (elastic#81579) Enable send to background in Vega (elastic#82229) Enable send to background in Timelion (elastic#82232) [Actions & Connectors] removes Connector flyouts after usage (elastic#82126) Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) ...
watson
added a commit
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #80713Closes #54168
This PR upgrades from hapi v17 to v18 (and related packages) and replaces PR #61959, which had become stale and drifted too far away from
master.See the hapi v18 release notes for details of the breaking changes (see also the 18.4.1 docs).
The reason why we do not upgrade directly to hapi v20 is because that version doesn't work with Node.js 10. Once we've upgraded to a newer Node.js version we can go ahead and upgrade hapi to version 20.
List of upgraded modules:
hapi@hapi/hapiboom@hapi/boomhapi-auth-cookie@hapi/cookieh2o2@hapi/h2o2hoek@hapi/hoekhapijs/hoek#299
hapijs/hoek#306
hapijs/hoek#315
inert@hapi/inertpodium@hapi/podiumstatehood@hapi/statehoodvision@hapi/visionFor now, our fork of
good(@elastic/good), hasn't been upgraded to@hapi/good. Likewise,joihasn't been upgraded to@hapi/joi.Note to reviewers
This PR might look very daunting since it's touching 244 files. However, 224 out of the 244 file-changes are just renaming the imports to include the
@hapi/prefix.