-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Add Metrics Anomaly Alert Type #89244
Conversation
# Conflicts: # x-pack/plugins/infra/server/lib/infra_ml/metrics_hosts_anomalies.ts # x-pack/plugins/infra/server/lib/infra_ml/metrics_k8s_anomalies.ts
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@sorantis Should this be called "Metrics Anomaly" or "Infrastructure Anomaly"? Docs call inventory alerts "Infrastructure Threshold" (https://www.elastic.co/guide/en/observability/master/infrastructure-threshold-alert.html) so I'm wondering if we should shift towards that naming convention |
@katefarrar Could use some feedback on this influencer filter component.
|
Infrastructure anomaly SGTM |
Talked with @Zacqary and we're going to implement the following changes:
|
@simianhacker Didn't realize the alert preview wasn't an accurate reflection of how the alert would perform. I'm pushing a fix, but it's unable to prevent firing the alert up to 15 times per anomaly. I think this alert type will greatly benefit from not changing the default With that in mind, this alert type probably really wants us to merge #89939 |
# Conflicts: # x-pack/plugins/infra/public/alerting/inventory/components/alert_dropdown.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/alert_dropdown.tsx # x-pack/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested my scenario and everything works as expected.
LGTM
x-pack/plugins/infra/server/lib/infra_ml/metrics_hosts_anomalies.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/server/lib/infra_ml/metrics_k8s_anomalies.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # x-pack/plugins/infra/public/types.ts # x-pack/plugins/infra/server/lib/infra_ml/metrics_hosts_anomalies.ts # x-pack/plugins/infra/server/lib/infra_ml/metrics_k8s_anomalies.ts # x-pack/plugins/infra/server/lib/infra_ml/queries/metrics_hosts_anomalies.ts # x-pack/plugins/infra/server/lib/infra_ml/queries/metrics_k8s_anomalies.ts
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sorry @Zacqary but once this was merged it started failing master builds in a critical way so I needed to revert it https://kibana-ci.elastic.co/job/elastic+kibana+baseline-capture/13507/execution/node/155/log/ Please resubmit in a new PR with master merged. Thanks! |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/infra/public/types.ts
* master: (99 commits) [Fleet] Use Fleet Server indices in the search bar (elastic#90835) [Search Sessions] added an info flyout to session management (elastic#90559) [ILM] Revisit searchable snapshot field after new redesign (elastic#90793) [Alerting] License Errors on Alert List View (elastic#89920) RFC Improve saved object migrations algorithm (elastic#84333) [Lens] (Accessibility) Fix focus on drag and drop actions (elastic#90561) Use new shortcut links to Fleet discuss forums. (elastic#90786) Do not generate an ephemeral encryption key in production. (elastic#81511) [Fleet] Use staging registry for snapshot builds (elastic#90327) Actually deleting x-pack/tsconfig.refs.json (elastic#90898) Add deprecation warning to all Beats CM pages. (elastic#90741) skip flaky suite (elastic#90136) Revert "Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)"" (elastic#90889) remove ref to removed tsconfig file [core.logging] Uses host timezone as default (elastic#90368) [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (elastic#90292) Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)" [dev-utils/ci-stats] support disabling ship errors (elastic#90851) Prefix with / (elastic#90836) [Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244) ...
Summary
Closes #74809
Adds the Metrics Anomaly alert type. Also revamps the alert dropdown to allow you to add anomaly alerts (and all alert types) from either the Inventory page or Metrics Explorer.
Alert UI
Influencer Filter Autocomplete
Dropdown UI
How To Test
Alert Type
UI
Checklist
Delete any items that are not applicable to this PR.