-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Fix alert preview accuracy with new Notify settings #89939
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Would be nice to have a unit test that AlertTypeParamsExpression is working with the new option as expected.
@elasticmachine merge upstream |
…into 88909-preview-notify-fix
jenkins test this |
@elasticmachine merge upstream |
…ify-fix # Conflicts: # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/preview_inventory_metric_threshold_alert.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/preview_metric_threshold_alert.ts
…into 88909-preview-notify-fix
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Firefox XPack UI Functional Tests.x-pack/test/functional/apps/grok_debugger/grok_debugger·js.logstash grok debugger app "before all" hook in "grok debugger app"Standard Out
Stack Trace
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
…stic#89939) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Closes #88909
The Alert Preview component will now correctly calculate notifications based on the
Notify
setting.Checklist
Delete any items that are not applicable to this PR.