Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Drag and drop info bottom bar POC implementation #91832

Closed
wants to merge 2 commits into from

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Feb 18, 2021

Summary

Fix #95630

  1. Black bar only appears when dragging an operation (is it correct?)
  2. When an element is dragged but it is not being dragged over, it displays this message - the message has to be re-thought as it doesn't say about all the options (reorder, duplicate):
    image

Other cases when an element is being dragged over:

  1. Replace incompatible:
    image
  2. Move incompatible:
    image
  3. Move compatible: "Drop to move to new dimension"
  4. Replace compatible: "Drop to replace existing dimension."
  5. Duplicate: "Drop to duplicate."
  6. Reorder: "Drop to reorder"

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 495 496 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 940.6KB 943.2KB +2.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
@mbondyra
Copy link
Contributor Author

Closing as we decided not to implement it.

@mbondyra mbondyra closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] drag and drop add instructions on the screen for the user
3 participants