Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix expanding document when using saved search data grid #92999

Merged
merged 5 commits into from
Mar 2, 2021
Merged

[Discover] Fix expanding document when using saved search data grid #92999

merged 5 commits into from
Mar 2, 2021

Conversation

kertal
Copy link
Member

@kertal kertal commented Mar 1, 2021 •
edited
Loading

Summary

On a dashboard, a search embeddable couldn't expand a document. This is fixed by this PR, and covered by a functional test (worked before but was broken with another fix)

Steps to reproduce:

  1. Make sure doc_table:legacy setting is off in Advanced settings
  2. Go to Dashboard
  3. Add Saved Search embeddable
  4. Expand a document of the embeddable
  5. Then you should see the selected document in a flyout.

Fixes #93005
Fixes #92938

Checklist

@kertal kertal added the Feature:Discover Discover Application label Mar 1, 2021
@kertal kertal self-assigned this Mar 1, 2021
@kertal kertal added Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v7.13.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 1, 2021
@kertal kertal marked this pull request as ready for review March 1, 2021 12:59
@kertal kertal requested a review from a team March 1, 2021 12:59
@kertal kertal requested a review from a team as a code owner March 1, 2021 12:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member Author

kertal commented Mar 1, 2021

@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented Mar 1, 2021

@elasticmachine merge upstream

majagrubic
majagrubic approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome on MAC OS and works as expected.

@kertal
Copy link
Member Author

kertal commented Mar 1, 2021

@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, tested locally in chrome.

Also, the data grid is looking great!

wylieconlon
wylieconlon approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tried to figure out what's causing the functional test failures, but I was not able to.

@kertal
Copy link
Member Author

kertal commented Mar 2, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 401.0KB 401.2KB +173.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal
Copy link
Member Author

kertal commented Mar 2, 2021

LGTM. I tried to figure out what's causing the functional test failures, but I was not able to.

@wylieconlon was the usual flakiness with random tests failing

@kertal kertal merged commit 5afe844 into elastic:master Mar 2, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
@gmmorris
Merge branch 'master' into task-manager/docs-monitoring
6b21146 
* master: (42 commits)
  [Lens] Introduces new chart switcher (elastic#91844)
  [Lens] fix selection when dragging (elastic#93034)
  Converts usage collection README to .mdx (elastic#92982)
  Fix expanding document when using saved search data grid (elastic#92999)
  [SECURITY SOLUTIONS] Bug case connector (elastic#93104)
  [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (elastic#92025)
  [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (elastic#92942)
  [APM] Fix hidden search bar in error pages while loading (elastic#84476) (elastic#93139)
  [DOCS] Fixes links for machine learning alerts (elastic#92744)
  [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (elastic#92748)
  [SecuritySolution][Case] Disable cases on detections in read-only mode (elastic#93010)
  [Security Solution][Case][Bug] Prevent closing collection when pushing (elastic#93095)
  [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (elastic#92667)
  Bump ems landing page to 7.12 (elastic#93065)
  [App Search] Implement various Relevance Tuning states and form actions (elastic#92644)
  [actions] for simplistic email servers, set rejectUnauthorized to false (elastic#91760)
  [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (elastic#93092)
  Hide instances latency distribution chart (elastic#92869)
  [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (elastic#93087)
  [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (elastic#92932)
  ...
v1v added a commit to shahzad31/kibana that referenced this pull request Mar 2, 2021
@v1v
Merge branch 'playwright-ftr-e2e' of github.com:shahzad31/kibana into…
dd35c42 
… playwright-ftr-e2e

* 'playwright-ftr-e2e' of github.com:shahzad31/kibana: (38 commits)
  [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)
  [Lens] Introduces new chart switcher (elastic#91844)
  [Lens] fix selection when dragging (elastic#93034)
  Converts usage collection README to .mdx (elastic#92982)
  Fix expanding document when using saved search data grid (elastic#92999)
  [SECURITY SOLUTIONS] Bug case connector (elastic#93104)
  [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (elastic#92025)
  [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (elastic#92942)
  [APM] Fix hidden search bar in error pages while loading (elastic#84476) (elastic#93139)
  [DOCS] Fixes links for machine learning alerts (elastic#92744)
  [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (elastic#92748)
  [SecuritySolution][Case] Disable cases on detections in read-only mode (elastic#93010)
  [Security Solution][Case][Bug] Prevent closing collection when pushing (elastic#93095)
  [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (elastic#92667)
  Bump ems landing page to 7.12 (elastic#93065)
  [App Search] Implement various Relevance Tuning states and form actions (elastic#92644)
  [actions] for simplistic email servers, set rejectUnauthorized to false (elastic#91760)
  [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (elastic#93092)
  Hide instances latency distribution chart (elastic#92869)
  [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (elastic#93087)
  ...
@kertal kertal mentioned this pull request Mar 2, 2021
Merged
1 task
jloleysens added a commit that referenced this pull request Mar 3, 2021
@jloleysens
Merge branch 'ilm/rollup-v2-action' of github.com:elastic/kibana into…
50eed10 
… ilm/rollup-v2-action

* 'ilm/rollup-v2-action' of github.com:elastic/kibana: (30 commits)
  Fix expanding document when using saved search data grid (#92999)
  [SECURITY SOLUTIONS] Bug case connector (#93104)
  [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (#92025)
  [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (#92942)
  [APM] Fix hidden search bar in error pages while loading (#84476) (#93139)
  [DOCS] Fixes links for machine learning alerts (#92744)
  [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (#92748)
  [SecuritySolution][Case] Disable cases on detections in read-only mode (#93010)
  [Security Solution][Case][Bug] Prevent closing collection when pushing (#93095)
  [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (#92667)
  Bump ems landing page to 7.12 (#93065)
  [App Search] Implement various Relevance Tuning states and form actions (#92644)
  [actions] for simplistic email servers, set rejectUnauthorized to false (#91760)
  [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (#93092)
  Hide instances latency distribution chart (#92869)
  [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (#93087)
  [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (#92932)
  [Security Solution][Detecttions] Indicator enrichment tweaks (#92989)
  [Maps] fix fit to data on heatmap not working (#92697)
  [Security Solution][Endpoint][Admin] Fixes policy sticky footer save test (#92919)
  ...
@wylieconlon
Copy link
Contributor

wylieconlon commented Mar 3, 2021 •
edited
Loading

@kertal it looks like you never backported this. It's blocking my new PR, so I'm adding backports.

@wylieconlon wylieconlon mentioned this pull request Mar 3, 2021
Merged
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Mar 3, 2021
@kertal @wylieconlon
Fix expanding document when using saved search data grid (elastic#92999)
d870da7
@wylieconlon wylieconlon mentioned this pull request Mar 3, 2021
Merged
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Mar 3, 2021
@kertal @wylieconlon
Fix expanding document when using saved search data grid (elastic#92999)
4bab588
@wylieconlon wylieconlon mentioned this pull request Mar 3, 2021
Merged
wylieconlon pushed a commit that referenced this pull request Mar 4, 2021
@kertal
Fix expanding document when using saved search data grid (#92999) (#9…
2faf3f4 
…3522)

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
wylieconlon pushed a commit that referenced this pull request Mar 4, 2021
@kertal
Fix expanding document when using saved search data grid (#92999) (#9…
faadbce 
…3523)

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
@kertal
Copy link
Member Author

kertal commented Mar 4, 2021

@kertal it looks like you never backported this. It's blocking my new PR, so I'm adding backports.

@wylieconlon thx a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wylieconlon wylieconlon wylieconlon approved these changes

@majagrubic majagrubic majagrubic approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

@kertal kertal

Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@kertal @elasticmachine @kibanamachine @wylieconlon @majagrubic @ThomThomson