Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Case][Bug] Prevent closing collection when pushing #93095

Merged
merged 2 commits into from
Mar 1, 2021
Merged

[Security Solution][Case][Bug] Prevent closing collection when pushing #93095

merged 2 commits into from
Mar 1, 2021

Conversation

jonathan-buttner
Copy link
Contributor

This PR prevents the push-to-close functionality from closing a collection type of case. Instead it will not update the status or create a user action for it. Collections status should not be changed because the status is not used. I also added another line to the description to indicate that the push-to-close functionality doesn't apply to the sub cases functionality currently.

image

@jonathan-buttner jonathan-buttner requested review from a team as code owners March 1, 2021 19:45
@jonathan-buttner jonathan-buttner added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0 v7.13.0 v8.0.0 labels Mar 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@jonathan-buttner jonathan-buttner added the Feature:Cases Cases feature label Mar 1, 2021
michaelolo24
michaelolo24 reviewed Mar 1, 2021
View reviewed changes
x-pack/plugins/case/server/client/cases/push.ts
@@ -37,6 +41,22 @@ import {
import { CaseClientHandler } from '../client';
import { createCaseError } from '../../common/error';

/**
* Returns true if the case should be closed based on the configuration settings and whether the case
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment, super helpful!

michaelolo24
michaelolo24 reviewed Mar 1, 2021
View reviewed changes
x-pack/plugins/case/server/client/cases/push.ts
* is a collection. Collections are not closable because we aren't allowing their status to be changed.
* In the future we could allow push to close all the sub cases of a collection but that's not currently supported.
*/
function shouldCloseByPush(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for moving this out to it's own fn

michaelolo24
michaelolo24 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for cleaning things up including all the translations 😄

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB +612.0B
triggersActionsUi 1.6MB 1.5MB -23.9KB
total -23.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jonathan-buttner jonathan-buttner merged commit 4739eab into elastic:master Mar 1, 2021
@jonathan-buttner jonathan-buttner deleted the disable-push-to-close branch March 1, 2021 22:11
jonathan-buttner added a commit to jonathan-buttner/kibana that referenced this pull request Mar 1, 2021
@jonathan-buttner
[Security Solution][Case][Bug] Prevent closing collection when pushing (
85553ed 
elastic#93095)

* Prevent closing collection when pushing

* Fixing translations
@jonathan-buttner jonathan-buttner mentioned this pull request Mar 1, 2021
Merged
jonathan-buttner added a commit to jonathan-buttner/kibana that referenced this pull request Mar 1, 2021
@jonathan-buttner
[Security Solution][Case][Bug] Prevent closing collection when pushing (
9122c78 
elastic#93095)

* Prevent closing collection when pushing

* Fixing translations
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@jonathan-buttner jonathan-buttner mentioned this pull request Mar 1, 2021
Merged
jonathan-buttner added a commit that referenced this pull request Mar 2, 2021
@jonathan-buttner
[Security Solution][Case][Bug] Prevent closing collection when pushing (
56f5570 
#93095) (#93142)

* Prevent closing collection when pushing

* Fixing translations
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
@gmmorris
Merge branch 'master' into task-manager/docs-monitoring
6b21146 
* master: (42 commits)
  [Lens] Introduces new chart switcher (elastic#91844)
  [Lens] fix selection when dragging (elastic#93034)
  Converts usage collection README to .mdx (elastic#92982)
  Fix expanding document when using saved search data grid (elastic#92999)
  [SECURITY SOLUTIONS] Bug case connector (elastic#93104)
  [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (elastic#92025)
  [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (elastic#92942)
  [APM] Fix hidden search bar in error pages while loading (elastic#84476) (elastic#93139)
  [DOCS] Fixes links for machine learning alerts (elastic#92744)
  [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (elastic#92748)
  [SecuritySolution][Case] Disable cases on detections in read-only mode (elastic#93010)
  [Security Solution][Case][Bug] Prevent closing collection when pushing (elastic#93095)
  [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (elastic#92667)
  Bump ems landing page to 7.12 (elastic#93065)
  [App Search] Implement various Relevance Tuning states and form actions (elastic#92644)
  [actions] for simplistic email servers, set rejectUnauthorized to false (elastic#91760)
  [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (elastic#93092)
  Hide instances latency distribution chart (elastic#92869)
  [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (elastic#93087)
  [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (elastic#92932)
  ...
v1v added a commit to shahzad31/kibana that referenced this pull request Mar 2, 2021
@v1v
Merge branch 'playwright-ftr-e2e' of github.com:shahzad31/kibana into…
dd35c42 
… playwright-ftr-e2e

* 'playwright-ftr-e2e' of github.com:shahzad31/kibana: (38 commits)
  [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)
  [Lens] Introduces new chart switcher (elastic#91844)
  [Lens] fix selection when dragging (elastic#93034)
  Converts usage collection README to .mdx (elastic#92982)
  Fix expanding document when using saved search data grid (elastic#92999)
  [SECURITY SOLUTIONS] Bug case connector (elastic#93104)
  [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (elastic#92025)
  [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (elastic#92942)
  [APM] Fix hidden search bar in error pages while loading (elastic#84476) (elastic#93139)
  [DOCS] Fixes links for machine learning alerts (elastic#92744)
  [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (elastic#92748)
  [SecuritySolution][Case] Disable cases on detections in read-only mode (elastic#93010)
  [Security Solution][Case][Bug] Prevent closing collection when pushing (elastic#93095)
  [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (elastic#92667)
  Bump ems landing page to 7.12 (elastic#93065)
  [App Search] Implement various Relevance Tuning states and form actions (elastic#92644)
  [actions] for simplistic email servers, set rejectUnauthorized to false (elastic#91760)
  [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (elastic#93092)
  Hide instances latency distribution chart (elastic#92869)
  [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (elastic#93087)
  ...
@jonathan-buttner jonathan-buttner mentioned this pull request Mar 2, 2021
Closed
30 tasks
jonathan-buttner added a commit that referenced this pull request Mar 2, 2021
@jonathan-buttner
[7.12] [Security Solution][Case][Bug] Prevent closing collection when…
17d97e9 
… pushing (#93095) (#93148)

* [Security Solution][Case][Bug] Prevent closing collection when pushing (#93095)

* Prevent closing collection when pushing

* Fixing translations
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json

* Fixing translations

* Removing translation changes

* Removing translation changes take 2
jloleysens added a commit that referenced this pull request Mar 3, 2021
@jloleysens
Merge branch 'ilm/rollup-v2-action' of github.com:elastic/kibana into…
50eed10 
… ilm/rollup-v2-action

* 'ilm/rollup-v2-action' of github.com:elastic/kibana: (30 commits)
  Fix expanding document when using saved search data grid (#92999)
  [SECURITY SOLUTIONS] Bug case connector (#93104)
  [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (#92025)
  [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (#92942)
  [APM] Fix hidden search bar in error pages while loading (#84476) (#93139)
  [DOCS] Fixes links for machine learning alerts (#92744)
  [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (#92748)
  [SecuritySolution][Case] Disable cases on detections in read-only mode (#93010)
  [Security Solution][Case][Bug] Prevent closing collection when pushing (#93095)
  [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (#92667)
  Bump ems landing page to 7.12 (#93065)
  [App Search] Implement various Relevance Tuning states and form actions (#92644)
  [actions] for simplistic email servers, set rejectUnauthorized to false (#91760)
  [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (#93092)
  Hide instances latency distribution chart (#92869)
  [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (#93087)
  [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (#92932)
  [Security Solution][Detecttions] Indicator enrichment tweaks (#92989)
  [Maps] fix fit to data on heatmap not working (#92697)
  [Security Solution][Endpoint][Admin] Fixes policy sticky footer save test (#92919)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathan-buttner @elasticmachine @kibanamachine @michaelolo24