[Discover] Unskip functional saved queries test #97220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
commented
Apr 19, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kertal
added
Feature:Discover
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mistic
approved these changes
Apr 19, 2021
This was referenced Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stablize saved queries, 2nd attempt. Adding a retry to check if the save button is disabled, when the users adds a duplicate name. Couldn't reproduce locally, but due to code analytics this could solve the flakiness.
Flaky test runner with 100 runs was successful: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1464/
Fixes #89477
Checklist