Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip functional saved queries test #97220

Merged
merged 2 commits into from
Apr 19, 2021
Merged

[Discover] Unskip functional saved queries test #97220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e165c57
Improve test
kertal Apr 15, 2021
2959f3f
Merge branch 'master' into kertal-pr-2021-04-15-unskip-saved-queries-…
kibanamachine Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions test/functional/apps/discover/_saved_queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const savedQueryManagementComponent = getService('savedQueryManagementComponent');
const testSubjects = getService('testSubjects');

// Failing: See https://github.com/elastic/kibana/issues/89477
describe.skip('saved queries saved objects', function describeIndexTests() {
describe('saved queries saved objects', function describeIndexTests() {
before(async function () {
log.debug('load kibana index with default index pattern');
await esArchiver.load('discover');
Expand Down Expand Up @@ -134,10 +133,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await savedQueryManagementComponent.saveNewQueryWithNameError('OkResponse');
});

it('does not allow saving a query with leading or trailing whitespace in the name', async () => {
kertal marked this conversation as resolved.
Show resolved Hide resolved
await savedQueryManagementComponent.saveNewQueryWithNameError('OkResponse ');
});

it('resets any changes to a loaded query on reloading the same saved query', async () => {
await savedQueryManagementComponent.loadSavedQuery('OkResponse');
await queryBar.setQuery('response:503');
Expand Down
15 changes: 7 additions & 8 deletions test/functional/services/saved_query_management_component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,14 @@ export function SavedQueryManagementComponentProvider({
// an error.
await testSubjects.click('savedQueryFormSaveButton');

const saveQueryFormSaveButtonStatus = await testSubjects.isEnabled(
'savedQueryFormSaveButton'
);
await retry.waitForWithTimeout('save button to be disabled', 1000, async () => {
const saveQueryFormSaveButtonStatus = await testSubjects.isEnabled(
'savedQueryFormSaveButton'
);
return saveQueryFormSaveButtonStatus === false;
});

try {
expect(saveQueryFormSaveButtonStatus).to.not.eql(true);
} finally {
await testSubjects.click('savedQueryFormCancelButton');
}
await testSubjects.click('savedQueryFormCancelButton');
}

public async saveCurrentlyLoadedAsNewQuery(
Expand Down