Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] min_version for anomaly detector model state is wrong #1545

Open
droberts195 opened this issue Oct 26, 2020 · 1 comment
Open

[ML] min_version for anomaly detector model state is wrong #1545

droberts195 opened this issue Oct 26, 2020 · 1 comment
Labels
>bug :ml

Comments

@droberts195
Copy link
Contributor

The min_version field for anomaly detector model state that stops model snapshots being loaded on nodes that are too old to understand then is currently incorrect. It is set to version 6.4.0, when we have updated the model state format more recently than that.

It's too late to correct released versions, but we can make some improvements:

  1. For 7.10.0 we can update the constant to the version where the previous breaking change to model state was made
  2. For 7.11.0 we can update the constant to version 7.11.0 to reflect the changes being made for time series decomposition and change point detection
@droberts195 droberts195 mentioned this issue Oct 26, 2020
Closed
@droberts195
Copy link
Contributor Author

  1. For 7.10.0 we can update the constant to the version where the previous breaking change to model state was made

I believe this was the change made in 7.9.0 in #1340

droberts195 added a commit to droberts195/ml-cpp that referenced this issue Oct 26, 2020
@droberts195
[ML] Correcting model state min_version
d5d90e6 
The model state min_version should indicate the minimum
node version required to restore the model state.  This
has not been updated since 6.4.0, meaning we have not had
the intended protection against model states being used on
nodes that are too old.  This change updates the
min_version to the correct version at present, which is
7.9.0 for latest state.

Relates elastic#1545
@droberts195 droberts195 mentioned this issue Oct 26, 2020
Merged
droberts195 added a commit that referenced this issue Oct 26, 2020
@droberts195
[ML] Correcting model state min_version (#1546)
2da1d33 
The model state min_version should indicate the minimum
node version required to restore the model state.  This
has not been updated since 6.4.0, meaning we have not had
the intended protection against model states being used on
nodes that are too old.  This change updates the
min_version to the correct version at present, which is
7.9.0 for latest state.

Relates #1545
@droberts195 droberts195 mentioned this issue Nov 24, 2021
Closed
droberts195 added a commit to droberts195/elasticsearch that referenced this issue Nov 25, 2021
@droberts195
[ML] In 8.x ML will have to tolerate model snapshots for 6.4.0+
7dc0825 
Previously we intended that 8.x ML would only accept model snapshots
created in version 7.0.0 or above. However, due to a bug
(elastic/ml-cpp#1545) it's not possible to distinguish model
snapshots created in versions 6.4.0-7.9.3 inclusive. Therefore,
to be sure of meeting the stated policy of accepting model snapshots
created in 7.0.0 or above ML will have to really accept those
labelled as 6.4.0 or above.

Fixes elastic#81011
@droberts195 droberts195 mentioned this issue Nov 25, 2021
Merged
droberts195 added a commit to elastic/elasticsearch that referenced this issue Nov 25, 2021
@droberts195
[ML] In 8.x ML will have to tolerate model snapshots for 6.4.0+ (#81039)
64338bf 
Previously we intended that 8.x ML would only accept model snapshots
created in version 7.0.0 or above. However, due to a bug
(elastic/ml-cpp#1545) it's not possible to distinguish model
snapshots created in versions 6.4.0-7.9.3 inclusive. Therefore,
to be sure of meeting the stated policy of accepting model snapshots
created in 7.0.0 or above ML will have to really accept those
labelled as 6.4.0 or above.

Fixes #81011
droberts195 added a commit to droberts195/elasticsearch that referenced this issue Nov 25, 2021
@droberts195
[ML] In 8.x ML will have to tolerate model snapshots for 6.4.0+ (elas…
9a5f603 
…tic#81039)

Previously we intended that 8.x ML would only accept model snapshots
created in version 7.0.0 or above. However, due to a bug
(elastic/ml-cpp#1545) it's not possible to distinguish model
snapshots created in versions 6.4.0-7.9.3 inclusive. Therefore,
to be sure of meeting the stated policy of accepting model snapshots
created in 7.0.0 or above ML will have to really accept those
labelled as 6.4.0 or above.

Fixes elastic#81011
elasticsearchmachine pushed a commit to elastic/elasticsearch that referenced this issue Nov 25, 2021
@droberts195
[ML] In 8.x ML will have to tolerate model snapshots for 6.4.0+ (#81039…
42ea3b8 
…) (#81048)

Previously we intended that 8.x ML would only accept model snapshots
created in version 7.0.0 or above. However, due to a bug
(elastic/ml-cpp#1545) it's not possible to distinguish model
snapshots created in versions 6.4.0-7.9.3 inclusive. Therefore,
to be sure of meeting the stated policy of accepting model snapshots
created in 7.0.0 or above ML will have to really accept those
labelled as 6.4.0 or above.

Fixes #81011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :ml
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@droberts195