Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Correcting model state min_version #1546

Merged

Conversation

droberts195
Copy link
Contributor

The model state min_version should indicate the minimum
node version required to restore the model state. This
has not been updated since 6.4.0, meaning we have not had
the intended protection against model states being used on
nodes that are too old. This change updates the
min_version to the correct version at present, which is
7.9.0 for latest state.

Relates #1545

The model state min_version should indicate the minimum
node version required to restore the model state.  This
has not been updated since 6.4.0, meaning we have not had
the intended protection against model states being used on
nodes that are too old.  This change updates the
min_version to the correct version at present, which is
7.9.0 for latest state.

Relates elastic#1545
Copy link
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but LGTM.

lib/api/CAnomalyJob.cc Show resolved Hide resolved
@droberts195 droberts195 merged commit 2da1d33 into elastic:master Oct 26, 2020
@droberts195 droberts195 deleted the correct_model_state_min_version branch October 26, 2020 17:36
droberts195 added a commit to droberts195/ml-cpp that referenced this pull request Oct 27, 2020
The model state min_version should indicate the minimum
node version required to restore the model state.  This
has not been updated since 6.4.0, meaning we have not had
the intended protection against model states being used on
nodes that are too old.  This change updates the
min_version to the correct version at present, which is
7.9.0 for latest state.

Backport of elastic#1546
droberts195 added a commit to droberts195/ml-cpp that referenced this pull request Oct 27, 2020
The model state min_version should indicate the minimum
node version required to restore the model state.  This
has not been updated since 6.4.0, meaning we have not had
the intended protection against model states being used on
nodes that are too old.  This change updates the
min_version to the correct version at present, which is
7.9.0 for latest state.

Backport of elastic#1546
droberts195 added a commit that referenced this pull request Oct 27, 2020
The model state min_version should indicate the minimum
node version required to restore the model state.  This
has not been updated since 6.4.0, meaning we have not had
the intended protection against model states being used on
nodes that are too old.  This change updates the
min_version to the correct version at present, which is
7.9.0 for latest state.

Backport of #1546
droberts195 added a commit that referenced this pull request Oct 27, 2020
The model state min_version should indicate the minimum
node version required to restore the model state.  This
has not been updated since 6.4.0, meaning we have not had
the intended protection against model states being used on
nodes that are too old.  This change updates the
min_version to the correct version at present, which is
7.9.0 for latest state.

Backport of #1546
droberts195 added a commit to elastic/elasticsearch that referenced this pull request Oct 27, 2020
Copies the release note for elastic/ml-cpp#1546 to where
it needs to be to get published
droberts195 added a commit to elastic/elasticsearch that referenced this pull request Oct 27, 2020
Copies the release note for elastic/ml-cpp#1546 to where
it needs to be to get published
2lambda123 pushed a commit to 2lambda123/elastic-elasticsearch that referenced this pull request May 2, 2024
Copies the release note for elastic/ml-cpp#1546 to where
it needs to be to get published
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants