Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run EA container + managed by fleet + standalone + autodiscovery #2366
Run EA container + managed by fleet + standalone + autodiscovery #2366
Changes from 3 commits
ed91154
fda02ee
3c1a6c0
8943aae
857accd
849203d
2a83c6e
761cb1b
19cd7c5
4f97593
65c4376
c9303ff
5fc2303
ee84ed9
055f367
54f9253
0127865
bb85343
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I think it will be confusing to users that we point to the module docs, but I don't have a better solution our standalone config docs are incomplete. :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed that is another good example that we refer to metricsets but we dont explain how agent uses them under the hood.
@dedemorton does it make sense to give as a note here a small explanation what metricset term is? or it becomes confusing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton #2384 relevant issue to track processors.
We can follow discussion there but is not urgent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gizas I've commented on your request. I'm actually working on the processors documentation right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think we should be using "dataset" here because that's the correct term to use when talking about Elastic Agent integrations. We are just in a really awkward position right now because the standalone configuration docs are incomplete (a deliberate decision by management to prioritize the Fleet docs over standalone because we have limited resources to work on all the docs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How Redis is relevant here? Right before we are talking about
scheduler
🤔 ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote about that to give the user the chance to check how that works. I rephrased a little bit to make it more clear: "Following the Redis example, if you deploy another Redis Pod with a different port, it should be detected. To check this, go, for example, to the field
service.address
undermetrics-redis.info-default
. It should be displaying two different services.". But even if this doesn't make sense now, we can remove it. What do you think?