-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run EA container + managed by fleet + standalone + autodiscovery #2366
Conversation
A documentation preview will be available soon: |
This pull request does not have a backport label. Could you fix it @constanca-m? 🙏
|
This pull request is now in conflict. Could you fix it @constanca-m? 🙏
|
...gement/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
...nt/elastic-agent/configuration/autodiscovery/elastic-agent-kubernetes-autodiscovery.asciidoc
Outdated
Show resolved
Hide resolved
…overy/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
…overy/elastic-agent-kubernetes-autodiscovery.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
...nt/elastic-agent/configuration/autodiscovery/elastic-agent-kubernetes-autodiscovery.asciidoc
Show resolved
Hide resolved
...gement/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
...gement/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
...gement/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
…overy/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
…overy/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
...-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/run-container-common/deploy-kube-state-metrics.asciidoc
Outdated
Show resolved
Hide resolved
…overy/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
…eploy-kube-state-metrics.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc
Outdated
Show resolved
Hide resolved
…managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc
Outdated
Show resolved
Hide resolved
…managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc
Outdated
Show resolved
Hide resolved
…managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
…managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
condition: ${kubernetes.labels.component} == 'kube-scheduler' | ||
---- | ||
|
||
WARNING: In some "As a Service" Kubernetes implementations, like GKE, the control plane nodes or even the Pods running on them won’t be visible. In these cases, it won’t be possible to use scheduler metricsets, necessary for this example. Refer https://www.elastic.co/guide/en/beats/metricbeat/current/metricbeat-module-kubernetes.html#_scheduler_and_controllermanager[scheduler and controller manager] to find more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In these cases, it won’t be possible to use scheduler metricsets, necessary for this example.
is scheduler is really necessary for this example? I mean in context of condition autodiscover?
It is quite confusing to have scheduler
sample in between of redis examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is important because readers get an idea how to set the host dynamically, and if we don't include it they may not get there on their own. I can only speak for myself, but as someone with little experience with Kubernetes, it would took me awhile to get there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we have the similar configuration for the redis:
hosts:
- '${kubernetes.pod.ip}:6379'
and with redis example can be achieved the same, no? (if there will be deployed multiple redis pods)
what I meant: it is confusing to get scheduler example, it doesn't seem to be relevant to what was said before - redis, and after - redis. Maybe it should be in separate block, not in == Example: Target Pods by label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first it was indeed a separate block. But after discussion, it changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't understand why example with scheduler is needed here, and what value does it bring if there exists already example with ${kubernetes.pod.ip}
.
As you already have enough reviews - you can merge this PR
...gement/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc
Show resolved
Hide resolved
...-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
...-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc
Show resolved
Hide resolved
...-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/run-container-common/kibana-fleet-data.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/running-on-kubernetes-standalone.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/running-on-kubernetes-standalone.asciidoc
Outdated
Show resolved
Hide resolved
…overy/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
...gement/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc
Outdated
Show resolved
Hide resolved
@constanca-m Will you be backporting this PR to 8.6? I tried to backport a change here, but noticed that your changes were not in 8.6. Let me know if you do decide to backport your PR so that I can make sure #2410 gets backported too. Thanks! |
* Run EA container + managed by fleet + standalone + autodiscovery * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/elastic-agent-kubernetes-autodiscovery.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/run-container-common/deploy-kube-state-metrics.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Apply suggestions. * Corrected Pod to pod on yaml * Changed provider link on autodiscover. * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com> * Some corrections. * Removed unnecessary annotations. Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com> (cherry picked from commit 4b8f02b)
…) (#2419) * Run EA container + managed by fleet + standalone + autodiscovery * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/elastic-agent-kubernetes-autodiscovery.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/run-container-common/deploy-kube-state-metrics.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Apply suggestions. * Corrected Pod to pod on yaml * Changed provider link on autodiscover. * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com> * Some corrections. * Removed unnecessary annotations. Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com> (cherry picked from commit 4b8f02b) Co-authored-by: Constança Manteigas <113898685+constanca-m@users.noreply.github.com>
…stic#2366) * Run EA container + managed by fleet + standalone + autodiscovery * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/elastic-agent-kubernetes-autodiscovery.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/run-container-common/deploy-kube-state-metrics.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Apply suggestions. * Corrected Pod to pod on yaml * Changed provider link on autodiscover. * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-managed-by-fleet.asciidoc Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-hints-autodiscover.asciidoc Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com> * Some corrections. * Removed unnecessary annotations. Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
The main changes of this PR are:
I tried to keep the common things like kube-state-metrics, deploy manifests etc in common docs files so it is easier to change them all at once if something changes in the future. I didn't change the common things in the new docs of managed by fleet.