Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run EA container + managed by fleet + standalone + autodiscovery #2366
Run EA container + managed by fleet + standalone + autodiscovery #2366
Changes from 16 commits
ed91154
fda02ee
3c1a6c0
8943aae
857accd
849203d
2a83c6e
761cb1b
19cd7c5
4f97593
65c4376
c9303ff
5fc2303
ee84ed9
055f367
54f9253
0127865
bb85343
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is scheduler is really necessary for this example? I mean in context of condition autodiscover?
It is quite confusing to have
scheduler
sample in between of redis examples.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is important because readers get an idea how to set the host dynamically, and if we don't include it they may not get there on their own. I can only speak for myself, but as someone with little experience with Kubernetes, it would took me awhile to get there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we have the similar configuration for the redis:
and with redis example can be achieved the same, no? (if there will be deployed multiple redis pods)
what I meant: it is confusing to get scheduler example, it doesn't seem to be relevant to what was said before - redis, and after - redis. Maybe it should be in separate block, not in
== Example: Target Pods by label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first it was indeed a separate block. But after discussion, it changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't understand why example with scheduler is needed here, and what value does it bring if there exists already example with
${kubernetes.pod.ip}
.As you already have enough reviews - you can merge this PR