Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document comparison of Alert Suppression, Snoozing, Exceptions, Maintenance Windows #3314

Merged
merged 6 commits into from
May 23, 2023

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented May 18, 2023

@joepeeples joepeeples added Team: Detections/Response Detections and Response v8.8.0 labels May 18, 2023
@joepeeples joepeeples self-assigned this May 18, 2023
@github-actions
Copy link

Documentation previews:

@joepeeples joepeeples marked this pull request as ready for review May 18, 2023 23:47
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new page is 💯 💯 very cool. Left the most trivial suggestion

docs/detections/alerts-reduce.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great and focused overview of all the different features. Just left a few optional suggestions for your consideration. Thanks for setting this up!

docs/detections/alerts-reduce.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-reduce.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-reduce.asciidoc Outdated Show resolved Hide resolved
joepeeples and others added 2 commits May 22, 2023 09:59
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and will definitely help our customers. Just some very tiny nits; looks good! ⭐

docs/detections/alerts-reduce.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-reduce.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-reduce.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@peluja1012 peluja1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this page. It's concise and explains the differences at a high level. Looks great!

joepeeples and others added 2 commits May 23, 2023 09:07
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
@joepeeples joepeeples merged commit 12483be into main May 23, 2023
mergify bot pushed a commit that referenced this pull request May 23, 2023
…enance Windows (#3314)

* First draft

* Add link to custom query rule docs

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Apply suggestions from code review

* Apply suggestions from Janeen's review

Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
(cherry picked from commit 12483be)
@joepeeples joepeeples deleted the 3153-compare-all-the-things branch May 23, 2023 13:24
joepeeples added a commit that referenced this pull request May 23, 2023
…enance Windows (#3314) (#3335)

* First draft

* Add link to custom query rule docs

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Apply suggestions from code review

* Apply suggestions from Janeen's review

Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
(cherry picked from commit 12483be)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@joepeeples joepeeples mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document comparison of Alert Suppression, Snoozing, Exceptions, Maintenance Windows
5 participants